From patchwork Sun Dec 16 23:56:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Ogilvie X-Patchwork-Id: 206749 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2BB372C00AC for ; Mon, 17 Dec 2012 10:57:03 +1100 (EST) Received: from localhost ([::1]:56781 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkO4r-00023U-4h for incoming@patchwork.ozlabs.org; Sun, 16 Dec 2012 18:57:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkO4a-00021A-46 for qemu-devel@nongnu.org; Sun, 16 Dec 2012 18:56:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TkO4W-0007Dj-Qv for qemu-devel@nongnu.org; Sun, 16 Dec 2012 18:56:44 -0500 Received: from qmta11.emeryville.ca.mail.comcast.net ([76.96.27.211]:34675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkO4W-0007DZ-IH for qemu-devel@nongnu.org; Sun, 16 Dec 2012 18:56:40 -0500 Received: from omta23.emeryville.ca.mail.comcast.net ([76.96.30.90]) by qmta11.emeryville.ca.mail.comcast.net with comcast id cPCw1k0031wfjNsABPwfUJ; Sun, 16 Dec 2012 23:56:39 +0000 Received: from mmogilvi.homeip.net ([75.70.117.91]) by omta23.emeryville.ca.mail.comcast.net with comcast id cPwd1k00e1yPlfP8jPwemQ; Sun, 16 Dec 2012 23:56:38 +0000 Received: by mmogilvi.homeip.net (Postfix, from userid 501) id B53EA1E9601C; Sun, 16 Dec 2012 16:56:37 -0700 (MST) From: Matthew Ogilvie To: qemu-devel@nongnu.org Date: Sun, 16 Dec 2012 16:56:20 -0700 Message-Id: <1355702189-6994-2-git-send-email-mmogilvi_qemu@miniinfo.net> X-Mailer: git-send-email 1.7.10.2.484.gcd07cc5 In-Reply-To: <1355702189-6994-1-git-send-email-mmogilvi_qemu@miniinfo.net> References: <1355702189-6994-1-git-send-email-mmogilvi_qemu@miniinfo.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1355702199; bh=mGW09Tb5WBUkPzFzzY2HGx81P96Rg0l871ScwtNq1rg=; h=Received:Received:Received:From:To:Subject:Date:Message-Id; b=jU3nlEdjJVo2xSKYTRhSVVZpcE/7Pp8yedcBgsUMZVDnftMSstH8B3ie6sCy5icXN L0TOki6WELzcfGgHWvynZZsg9KPawxUEy8LVS/Y8vff2DCtB8V+Ch1JRFjG3SBs8Zy iQNDXmsHhfwsp2+pmlik547w1lPytv2nbHv08pfXLh55OILQuuyTtMr9TYbo2g8Cxd yUTXLdlYcDymueiN9ofYpuRUsps3CuaoEOp24zTNSonQjsplwXWlVDhxOomGgx+Hiw EimsT7mbXvtv+TnCnw0YL4h3Ck0SB5hSoXmPE1YGteGepMJnAyc5/7d6yIGqynoSha crel+ta30KvzQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 76.96.27.211 Cc: "Maciej W. Rozycki" , Jan Kiszka , Matthew Ogilvie , Gleb Natapov Subject: [Qemu-devel] [PATCH v8 01/10] fix some debug printf format strings X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org These are normally ifdefed out and don't matter. But if you enable them, they ought to be correct. Signed-off-by: Matthew Ogilvie --- hw/cirrus_vga.c | 4 ++-- hw/i8259.c | 3 ++- hw/ide/cmd646.c | 5 +++-- hw/ide/via.c | 5 +++-- 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 40efa8a..84f2f16 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -2053,8 +2053,8 @@ static void cirrus_vga_mem_write(void *opaque, } } else { #ifdef DEBUG_CIRRUS - printf("cirrus: mem_writeb " TARGET_FMT_plx " value %02x\n", addr, - mem_value); + printf("cirrus: mem_writeb " TARGET_FMT_plx " value %02" PRIx64 "\n", + addr, mem_value); #endif } } diff --git a/hw/i8259.c b/hw/i8259.c index af0ba4d..60c25ba 100644 --- a/hw/i8259.c +++ b/hw/i8259.c @@ -355,7 +355,8 @@ static uint64_t pic_ioport_read(void *opaque, hwaddr addr, ret = s->imr; } } - DPRINTF("read: addr=0x%02x val=0x%02x\n", addr, ret); + DPRINTF("read: addr=0x%02" TARGET_PRIxPHYS " val=0x%02x\n", + addr, ret); return ret; } diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 804db60..72ceaaf 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -154,7 +154,7 @@ static uint64_t bmdma_read(void *opaque, hwaddr addr, break; } #ifdef DEBUG_IDE - printf("bmdma: readb 0x%02x : 0x%02x\n", addr, val); + printf("bmdma: readb 0x%02" TARGET_PRIxPHYS " : 0x%02x\n", addr, val); #endif return val; } @@ -170,7 +170,8 @@ static void bmdma_write(void *opaque, hwaddr addr, } #ifdef DEBUG_IDE - printf("bmdma: writeb 0x%02x : 0x%02x\n", addr, val); + printf("bmdma: writeb 0x%02" TARGET_PRIxPHYS " : 0x%02" PRIx64 "\n", + addr, val); #endif switch(addr & 3) { case 0: diff --git a/hw/ide/via.c b/hw/ide/via.c index efda173..10ba9b5 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -55,7 +55,7 @@ static uint64_t bmdma_read(void *opaque, hwaddr addr, break; } #ifdef DEBUG_IDE - printf("bmdma: readb 0x%02x : 0x%02x\n", addr, val); + printf("bmdma: readb 0x%02" TARGET_PRIxPHYS " : 0x%02x\n", addr, val); #endif return val; } @@ -70,7 +70,8 @@ static void bmdma_write(void *opaque, hwaddr addr, } #ifdef DEBUG_IDE - printf("bmdma: writeb 0x%02x : 0x%02x\n", addr, val); + printf("bmdma: writeb 0x%02" TARGET_PRIxPHYS " : 0x%02" PRIx64 "\n", + addr, val); #endif switch (addr & 3) { case 0: