From patchwork Fri Dec 14 16:46:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Freimann X-Patchwork-Id: 206523 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4383C2C0079 for ; Sat, 15 Dec 2012 03:47:16 +1100 (EST) Received: from localhost ([::1]:34091 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjYPq-0003Au-FN for incoming@patchwork.ozlabs.org; Fri, 14 Dec 2012 11:47:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjYPa-00039F-1D for qemu-devel@nongnu.org; Fri, 14 Dec 2012 11:47:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjYPX-0002s6-In for qemu-devel@nongnu.org; Fri, 14 Dec 2012 11:46:57 -0500 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:56818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjYPX-0002rk-9Z for qemu-devel@nongnu.org; Fri, 14 Dec 2012 11:46:55 -0500 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 14 Dec 2012 16:46:37 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp17.uk.ibm.com (192.168.101.147) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 14 Dec 2012 16:46:36 -0000 Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qBEGkhOn6095290 for ; Fri, 14 Dec 2012 16:46:43 GMT Received: from d06av04.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qBEGkpgT023183 for ; Fri, 14 Dec 2012 09:46:51 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id qBEGkoDc023171; Fri, 14 Dec 2012 09:46:50 -0700 Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 1122) id BEEF4122442E; Fri, 14 Dec 2012 17:46:50 +0100 (CET) From: Jens Freimann To: Alexander Graf Date: Fri, 14 Dec 2012 17:46:45 +0100 Message-Id: <1355503606-54131-3-git-send-email-jfrei@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.12.4 In-Reply-To: <1355503606-54131-1-git-send-email-jfrei@linux.vnet.ibm.com> References: <1355503606-54131-1-git-send-email-jfrei@linux.vnet.ibm.com> x-cbid: 12121416-0542-0000-0000-000003E2F650 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 195.75.94.113 Cc: Heinz Graalfs , qemu-devel , Andreas Faerber , Christian Borntraeger , Jens Freimann , Cornelia Huck , Einar Lueck Subject: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann --- v2 -> v3: * explain in comment which code sets cpu 0 to running during IPL v1 -> v2: * move setting of control registers and psa to s390_cpu_reset and call it from the new s390_machine_cpu_reset_cb() This makes it more similar to how it is done on x86 * in s390_cpu_reset() set env->halted state of cpu after the memset. This is needed to keep our s390_cpu_running counter in sync when s390_cpu_reset is called via the qemu_devices_reset path * set env->halted state in s390_cpu_initfn to 1 to avoid decrementing the cpu counter during first reset --- target-s390x/cpu.c | 32 ++++++++++++++++++++++++++++++-- target-s390x/kvm.c | 9 ++++++++- 2 files changed, 38 insertions(+), 3 deletions(-) diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c index 619b202..75d4036 100644 --- a/target-s390x/cpu.c +++ b/target-s390x/cpu.c @@ -4,6 +4,7 @@ * Copyright (c) 2009 Ulrich Hecht * Copyright (c) 2011 Alexander Graf * Copyright (c) 2012 SUSE LINUX Products GmbH + * Copyright (c) 2012 IBM Corp. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -18,9 +19,13 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see * + * Contributions after 2012-12-11 are licensed under the terms of the + * GNU GPL, version 2 or (at your option) any later version. + * */ #include "cpu.h" +#include "hw/hw.h" #include "qemu-common.h" #include "qemu-timer.h" @@ -37,12 +42,30 @@ static void s390_cpu_reset(CPUState *s) log_cpu_state(env, 0); } - scc->parent_reset(s); + s390_del_running_cpu(env); + scc->parent_reset(s); memset(env, 0, offsetof(CPUS390XState, breakpoints)); + + /* architectured initial values for CR 0 and 14 */ + env->cregs[0] = 0xE0UL; + env->cregs[14] = 0xC2000000UL; + /* set to z/Architecture mode */ + env->psw.mask = 0x0000000180000000ULL; + env->psa = 0; + /* set halted to 1 to make sure we can add the cpu in + * s390_ipl_cpu code, where env->halted is set back to 0 + * after incrementing the cpu counter */ + env->halted = 1; /* FIXME: reset vector? */ tlb_flush(env, 1); - s390_add_running_cpu(env); +} + +static void s390_cpu_machine_reset_cb(void *opaque) +{ + S390CPU *cpu = opaque; + + cpu_reset(CPU(cpu)); } static void s390_cpu_initfn(Object *obj) @@ -66,7 +89,12 @@ static void s390_cpu_initfn(Object *obj) env->cpu_num = cpu_num++; env->ext_index = -1; + /* set env->halted state to 1 to avoid decrementing the running + * cpu counter in s390_cpu_reset to a negative number at + * initial ipl */ + env->halted = 1; cpu_reset(CPU(cpu)); + qemu_register_reset(s390_cpu_machine_reset_cb, cpu); } static void s390_cpu_class_init(ObjectClass *oc, void *data) diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c index 94de764..fda9f1f 100644 --- a/target-s390x/kvm.c +++ b/target-s390x/kvm.c @@ -85,7 +85,14 @@ int kvm_arch_init_vcpu(CPUS390XState *env) void kvm_arch_reset_vcpu(CPUS390XState *env) { - /* FIXME: add code to reset vcpu. */ + /* The initial reset call is needed here to reset in-kernel + * vcpu data that we can't access directly from QEMU + * (i.e. with older kernels which don't support sync_regs/ONE_REG). + * Before this ioctl cpu_synchronize_state() is called in common kvm + * code (kvm-all) */ + if (kvm_vcpu_ioctl(env, KVM_S390_INITIAL_RESET, NULL)) { + perror("Can't reset vcpu\n"); + } } int kvm_arch_put_registers(CPUS390XState *env, int level)