From patchwork Fri Dec 14 16:28:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 206521 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 0102D2C0089 for ; Sat, 15 Dec 2012 03:29:21 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1356107362; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=HdkvDlx hA9sNAREcK8CoRmfsHHI=; b=rMyLuUVi811g4smVQewJvdeB6BBFteWBDdf1FDa qWbgtyJmSkhKsM88VWphEzb8zltVGBsIJ3JMtqvW6UtWoFBDkRrWh9tuZ6ai9/Vp I462n/aUzVWb1J9iwroPHsgH44jEsPW9A46SeMUOXoppntNSemB8wUZq+AL2agO2 n0M8= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Q4y8FfNbw8Lc/6+I6jTjsUtNN9S+sDMjr5WRZ3BuVilnGiZH8xX/wJXFwRp5Gt 65de3Lj1adYYzscsUxqemOaq5j9sBDiG/7YOaS3Snk5VKONyaXxYskbs+INdvu/8 +7MynQIY/WQ7Jn7fp8I5/N+LyrlyvVIBHVG8kJCzzZJ6I=; Received: (qmail 23709 invoked by alias); 14 Dec 2012 16:29:08 -0000 Received: (qmail 23696 invoked by uid 22791); 14 Dec 2012 16:29:05 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Dec 2012 16:28:57 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBEGSvn0015249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 14 Dec 2012 11:28:57 -0500 Received: from anchor.twiddle.home (vpn-232-44.phx2.redhat.com [10.3.232.44]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qBEGSu0n020042; Fri, 14 Dec 2012 11:28:57 -0500 Message-ID: <50CB53C8.6030904@redhat.com> Date: Fri, 14 Dec 2012 08:28:56 -0800 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: GCC Patches CC: yvan.roux@linaro.org Subject: [COMMITTED] Tweak to patch for PR55492 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Yvan noticed that the set of memory models has already been validated by expand_builtin_atomic_store, so the test here in expand_atomic_store is fully redundant. Committed. r~ * optabs.c (expand_atomic_store): Elide redundant model test. diff --git a/gcc/optabs.c b/gcc/optabs.c index 99fd025..4f3cbb4 100644 --- a/gcc/optabs.c +++ b/gcc/optabs.c @@ -7537,8 +7537,7 @@ expand_atomic_store (rtx mem, rtx val, enum memmodel model, bool use_release) } /* Otherwise assume stores are atomic, and emit the proper barriers. */ - if (model == MEMMODEL_SEQ_CST || model == MEMMODEL_RELEASE) - expand_mem_thread_fence (model); + expand_mem_thread_fence (model); emit_move_insn (mem, val);