From patchwork Fri Dec 14 12:13:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [01/40] pseries: Fix incorrect initialization of interrupt controller From: Alexander Graf X-Patchwork-Id: 206422 Message-Id: <1355487236-27451-2-git-send-email-agraf@suse.de> To: "qemu-ppc@nongnu.org List" Cc: qemu-devel qemu-devel , David Gibson Date: Fri, 14 Dec 2012 13:13:17 +0100 From: David Gibson Currently in the reset code for the XICS interrupt controller, we initialize the pending_priority field to 0 (most favored, by XICS convention). This is incorrect, since there is no pending interrupt, it should be set to least favored - 0xff. At the moment our XICS implementation doesn't get hurt by this edge case, but it does confuse the upcoming kernel XICS implementation. Signed-off-by: David Gibson Signed-off-by: Alexander Graf --- hw/xics.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xics.c b/hw/xics.c index 1da3106..edf5833 100644 --- a/hw/xics.c +++ b/hw/xics.c @@ -495,7 +495,7 @@ static void xics_reset(void *opaque) for (i = 0; i < icp->nr_servers; i++) { icp->ss[i].xirr = 0; - icp->ss[i].pending_priority = 0; + icp->ss[i].pending_priority = 0xff; icp->ss[i].mfrr = 0xff; /* Make all outputs are deasserted */ qemu_set_irq(icp->ss[i].output, 0);