Patchwork [Netperf] output remote_send_size in TCP_MAERTS result

login
register
mail settings
Submitter Amos Kong
Date Dec. 14, 2012, 10:49 a.m.
Message ID <1355482148-31407-1-git-send-email-akong@redhat.com>
Download mbox | patch
Permalink /patch/206385/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Amos Kong - Dec. 14, 2012, 10:49 a.m.
When I executed TCP_MAERTS by following command line:
  netperf-2.6.0 -H 192.168.58.23 -l 10 -C -t TCP_MAERTS -- -m 512,1024
The outputed send size is '512'.

When I executed TCP_MAERTS by following command line:
  netperf-2.6.0 -H 192.168.58.23 -l 10 -t TCP_MAERTS -- -m 512,1024
The outputed send size is '1024'.

In TCP_MAERTS test, we should output the remote send size '1024',
this patch fixed this issue.

Reported-by: Wenli Quan <wquan@redhat.com>
Signed-off-by: Amos Kong <akong@redhat.com>
---
 src/nettest_omni.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Rick Jones - Dec. 14, 2012, 9:27 p.m.
On 12/14/2012 02:49 AM, Amos Kong wrote:
> When I executed TCP_MAERTS by following command line:
>    netperf-2.6.0 -H 192.168.58.23 -l 10 -C -t TCP_MAERTS -- -m 512,1024
> The outputed send size is '512'.
>
> When I executed TCP_MAERTS by following command line:
>    netperf-2.6.0 -H 192.168.58.23 -l 10 -t TCP_MAERTS -- -m 512,1024
> The outputed send size is '1024'.
>
> In TCP_MAERTS test, we should output the remote send size '1024',
> this patch fixed this issue.

Hi Amos -

While I suspect at least a few folks on the netdev list are interested 
in "things netperf," netperf is not maintained via the netdev list. 
There are two lists hosted on netperf.org which pertain to "things 
netperf."  The first is netperf-talk which is geared towards users.  The 
second netperf-dev which is geared towards those developing netperf.

No need to re-post there this time (though feel free to for the 
archives), I've gone ahead and applied the fix to the netperf top-of-trunk.

happy benchmarking,

rick jones
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/src/nettest_omni.c b/src/nettest_omni.c
index 826167a..b0b1500 100644
--- a/src/nettest_omni.c
+++ b/src/nettest_omni.c
@@ -5951,7 +5951,7 @@  Size (bytes)\n\
 		cpu_fmt_1,		/* the format string */
 		rsr_size,		/* remote recvbuf size */
 		lss_size,		/* local sendbuf size */
-		send_size,		/* how large were the recvs */
+		remote_send_size,	/* how large were the recvs */
 		elapsed_time,		/* how long was the test */
 		thruput, 		/* what was the xfer rate */
 		local_cpu_utilization,	/* local cpu */
@@ -5983,7 +5983,7 @@  Size (bytes)\n\
 		tput_fmt_1,		/* the format string */
 		lsr_size, 		/* local recvbuf size */
 		rss_size, 		/* remot sendbuf size */
-		remote_send_size,		/* how large were the recvs */
+		remote_send_size,	/* how large were the recvs */
 		elapsed_time, 		/* how long did it take */
 		thruput,                  /* how fast did it go */
 		((print_headers) ||