Patchwork [3/3] uefirttime: unload the efi_runtime module when deinit the test

login
register
mail settings
Submitter IvanHu
Date Dec. 14, 2012, 9:50 a.m.
Message ID <1355478608-25502-1-git-send-email-ivan.hu@canonical.com>
Download mbox | patch
Permalink /patch/206380/
State Accepted
Headers show

Comments

IvanHu - Dec. 14, 2012, 9:50 a.m.
Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 src/uefi/uefirttime/uefirttime.c |    1 +
 1 file changed, 1 insertion(+)
Colin King - Dec. 14, 2012, 10:31 a.m.
On 14/12/12 09:50, Ivan Hu wrote:
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>   src/uefi/uefirttime/uefirttime.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c
> index 78b5a3b..f038ebd 100644
> --- a/src/uefi/uefirttime/uefirttime.c
> +++ b/src/uefi/uefirttime/uefirttime.c
> @@ -189,6 +189,7 @@ static int uefirttime_deinit(fwts_framework *fw)
>   	FWTS_UNUSED(fw);
>
>   	close(fd);
> +	fwts_lib_efi_runtime_unload_module(fw);
>
>   	return FWTS_OK;
>   }
>

Good catch, I missed that on earlier patches.

Acked-by: Colin Ian King <colin.king@canonical.com>
Alex Hung - Dec. 21, 2012, 2:02 a.m.
On 12/14/2012 05:50 PM, Ivan Hu wrote:
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>   src/uefi/uefirttime/uefirttime.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c
> index 78b5a3b..f038ebd 100644
> --- a/src/uefi/uefirttime/uefirttime.c
> +++ b/src/uefi/uefirttime/uefirttime.c
> @@ -189,6 +189,7 @@ static int uefirttime_deinit(fwts_framework *fw)
>   	FWTS_UNUSED(fw);
>
>   	close(fd);
> +	fwts_lib_efi_runtime_unload_module(fw);
>
>   	return FWTS_OK;
>   }
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c
index 78b5a3b..f038ebd 100644
--- a/src/uefi/uefirttime/uefirttime.c
+++ b/src/uefi/uefirttime/uefirttime.c
@@ -189,6 +189,7 @@  static int uefirttime_deinit(fwts_framework *fw)
 	FWTS_UNUSED(fw);
 
 	close(fd);
+	fwts_lib_efi_runtime_unload_module(fw);
 
 	return FWTS_OK;
 }