From patchwork Thu Dec 13 22:04:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [7/8] lib/ext2fs/qcow2.h: Fix #defined 1<<63 values to be unsigned. Date: Thu, 13 Dec 2012 12:04:31 -0000 From: Sami Liedes X-Patchwork-Id: 206261 Message-Id: <20121213220431.GO9713@sli.dy.fi> To: linux-ext4@vger.kernel.org QCOW_OFLAG_COPIED in qcow2.h and e2image.c was defined as a signed value, which however does not fit in a signed 64-bit integer. Caught by clang -fsanitize=undefined. Signed-off-by: Sami Liedes --- lib/ext2fs/qcow2.h | 4 ++-- misc/e2image.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ext2fs/qcow2.h b/lib/ext2fs/qcow2.h index 81e0ec9..b997653 100644 --- a/lib/ext2fs/qcow2.h +++ b/lib/ext2fs/qcow2.h @@ -30,8 +30,8 @@ #define QCOW_MAGIC (('Q' << 24) | ('F' << 16) | ('I' << 8) | 0xfb) #define QCOW_VERSION 2 -#define QCOW_OFLAG_COPIED (1LL << 63) -#define QCOW_OFLAG_COMPRESSED (1LL << 62) +#define QCOW_OFLAG_COPIED (1LLU << 63) +#define QCOW_OFLAG_COMPRESSED (1LLU << 62) #define QCOW_COMPRESSED 1 #define QCOW_ENCRYPTED 2 diff --git a/misc/e2image.c b/misc/e2image.c index e6ea52a..36769c1 100644 --- a/misc/e2image.c +++ b/misc/e2image.c @@ -47,7 +47,7 @@ extern int optind; #include "../version.h" #include "nls-enable.h" -#define QCOW_OFLAG_COPIED (1LL << 63) +#define QCOW_OFLAG_COPIED (1LLU << 63) const char * program_name = "e2image";