Patchwork vmmouse_reset(): remove minimal code duplication

login
register
mail settings
Submitter Laszlo Ersek
Date Dec. 13, 2012, 2:01 p.m.
Message ID <1355407309-7138-1-git-send-email-lersek@redhat.com>
Download mbox | patch
Permalink /patch/206091/
State New
Headers show

Comments

Laszlo Ersek - Dec. 13, 2012, 2:01 p.m.
Commit 069ab0eb added a vmmouse_disable() call to vmmouse_reset().
vmmouse_disable() resets the status already.

Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 hw/vmmouse.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Stefan Hajnoczi - Dec. 18, 2012, 4:38 p.m.
On Thu, Dec 13, 2012 at 03:01:49PM +0100, Laszlo Ersek wrote:
> Commit 069ab0eb added a vmmouse_disable() call to vmmouse_reset().
> vmmouse_disable() resets the status already.
> 
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  hw/vmmouse.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/hw/vmmouse.c b/hw/vmmouse.c
index 6338efa..578122c 100644
--- a/hw/vmmouse.c
+++ b/hw/vmmouse.c
@@ -252,7 +252,6 @@  static void vmmouse_reset(DeviceState *d)
 {
     VMMouseState *s = container_of(d, VMMouseState, dev.qdev);
 
-    s->status = 0xffff;
     s->queue_size = VMMOUSE_QUEUE_SIZE;
 
     vmmouse_disable(s);