Patchwork [127/241] x86, efi: Fix processor-specific memcpy() build error

mail settings
Submitter Herton Ronaldo Krzesinski
Date Dec. 13, 2012, 1:58 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/205977/
State New
Headers show


Herton Ronaldo Krzesinski - Dec. 13, 2012, 1:58 p.m. -stable review patch.  If anyone has any objections, please let me know.


From: Matt Fleming <>

commit 0f905a43ce955b638139bd84486194770a6a2c08 upstream.

Building for Athlon/Duron/K7 results in the following build error,

arch/x86/boot/compressed/eboot.o: In function `__constant_memcpy3d':
eboot.c:(.text+0x385): undefined reference to `_mmx_memcpy'
arch/x86/boot/compressed/eboot.o: In function `efi_main':
eboot.c:(.text+0x1a22): undefined reference to `_mmx_memcpy'

because the boot stub code doesn't link with the kernel proper, and
therefore doesn't have access to the 3DNow version of memcpy. So,
follow the example of misc.c and #undef memcpy so that we use the
version provided by misc.c.


Reported-by: Al Viro <>
Reported-by: Ryan Underwood <>
Cc: H. Peter Anvin <>
Signed-off-by: Matt Fleming <>
Signed-off-by: Herton Ronaldo Krzesinski <>
 arch/x86/boot/compressed/eboot.c |    2 ++
 1 file changed, 2 insertions(+)


diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index 4e85f5f..f204178 100644
--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -12,6 +12,8 @@ 
 #include <asm/setup.h>
 #include <asm/desc.h>
+#undef memcpy			/* Use memcpy from misc.c */
 #include "eboot.h"
 static efi_system_table_t *sys_table;