Patchwork remove noisy message from llcp_sock_sendmsg

login
register
mail settings
Submitter Dave Jones
Date Dec. 13, 2012, 4:11 a.m.
Message ID <20121213041134.GA1611@redhat.com>
Download mbox | patch
Permalink /patch/205719/
State Accepted
Delegated to: David Miller
Headers show

Comments

Dave Jones - Dec. 13, 2012, 4:11 a.m.
This is easily triggerable when fuzz-testing as an unprivileged user.
We could rate-limit it, but given we don't print similar messages
for other protocols, I just removed it.

Signed-off-by: Dave Jones <davej@redhat.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Dec. 13, 2012, 6:01 p.m.
From: Dave Jones <davej@redhat.com>
Date: Wed, 12 Dec 2012 23:11:34 -0500

> This is easily triggerable when fuzz-testing as an unprivileged user.
> We could rate-limit it, but given we don't print similar messages
> for other protocols, I just removed it.
> 
> Signed-off-by: Dave Jones <davej@redhat.com>

Applied.

Please provide appropriate "xxx: " prefixes in your subject lines
for patch submissions.  "nfc: " would have been appropriate for
this one.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/nfc/llcp/sock.c b/net/nfc/llcp/sock.c
index 0fa1e92..fea22eb 100644
--- a/net/nfc/llcp/sock.c
+++ b/net/nfc/llcp/sock.c
@@ -614,10 +614,6 @@  static int llcp_sock_sendmsg(struct kiocb *iocb, struct socket *sock,
 
 		if (msg->msg_namelen < sizeof(*addr)) {
 			release_sock(sk);
-
-			pr_err("Invalid socket address length %d\n",
-			       msg->msg_namelen);
-
 			return -EINVAL;
 		}