Patchwork cmos: cmosdump: add in some previously unknown RTC settings

login
register
mail settings
Submitter Colin King
Date Dec. 12, 2012, 11:48 p.m.
Message ID <1355356112-7179-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/205690/
State Accepted
Headers show

Comments

Colin King - Dec. 12, 2012, 11:48 p.m.
From: Colin Ian King <colin.king@canonical.com>

I've found a datasheet that describes some of the RTC settings
so now we can have a more complete idea of the periodic rates.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/cmos/cmosdump/cmosdump.c | 38 +++++++++++++++++++-------------------
 1 file changed, 19 insertions(+), 19 deletions(-)
Keng-Yu Lin - Dec. 18, 2012, 2:52 a.m.
On Thu, Dec 13, 2012 at 7:48 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> I've found a datasheet that describes some of the RTC settings
> so now we can have a more complete idea of the periodic rates.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/cmos/cmosdump/cmosdump.c | 38 +++++++++++++++++++-------------------
>  1 file changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/src/cmos/cmosdump/cmosdump.c b/src/cmos/cmosdump/cmosdump.c
> index 83923bf..7efb342 100644
> --- a/src/cmos/cmosdump/cmosdump.c
> +++ b/src/cmos/cmosdump/cmosdump.c
> @@ -87,32 +87,32 @@ static int cmosdump_test1(fwts_framework *fw)
>         };
>
>         static char *divider[8] = {
> -               "unknown",
> -               "unknown",
> +               "4.194 MHz",
> +               "1.049 MHz",
>                 "32.768 KHz (default)",
>                 "unknown",
> -               "unknown",
> -               "unknown",
> -               "unknown",
> -               "unknown",
> +               "test mode",
> +               "test mode",
> +               "reset / disable",
> +               "reset / disable",
>         };
>
>         static char *rate_selection[16] = {
>                 "none",
> -               "unknown",
> -               "unknown",
> -               "122 microseconds (minimum)",
> -               "unknown",
> -               "unknown",
> +               "3.90625 millseconds",
> +               "7.8215 milliseconds",
> +               "122.070 microseconds",
> +               "244.141 microseconds",
> +               "488.281 microseconds",
>                 "976.562 microseconds (default)",
> -               "unknown",
> -               "unknown",
> -               "unknown",
> -               "unknown",
> -               "unknown",
> -               "unknown",
> -               "unknown",
> -               "unknown",
> +               "1.953125 milliseconds",
> +               "3.90625 milliseconds",
> +               "7.8215 milliseconds",
> +               "15.625 milliseconds",
> +               "31.25 milliseconds",
> +               "62.5 milliseconds",
> +               "125 milliseconds",
> +               "250 milliseconds",
>                 "500 milliseconds"
>         };
>
> --
> 1.8.0
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Dec. 20, 2012, 3:11 a.m.
On 12/13/2012 07:48 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> I've found a datasheet that describes some of the RTC settings
> so now we can have a more complete idea of the periodic rates.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/cmos/cmosdump/cmosdump.c | 38 +++++++++++++++++++-------------------
>   1 file changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/src/cmos/cmosdump/cmosdump.c b/src/cmos/cmosdump/cmosdump.c
> index 83923bf..7efb342 100644
> --- a/src/cmos/cmosdump/cmosdump.c
> +++ b/src/cmos/cmosdump/cmosdump.c
> @@ -87,32 +87,32 @@ static int cmosdump_test1(fwts_framework *fw)
>   	};
>
>   	static char *divider[8] = {
> -		"unknown",
> -		"unknown",
> +		"4.194 MHz",
> +		"1.049 MHz",
>   		"32.768 KHz (default)",
>   		"unknown",
> -		"unknown",
> -		"unknown",
> -		"unknown",
> -		"unknown",
> +		"test mode",
> +		"test mode",
> +		"reset / disable",
> +		"reset / disable",
>   	};
>
>   	static char *rate_selection[16] = {
>   		"none",
> -		"unknown",
> -		"unknown",
> -		"122 microseconds (minimum)",
> -		"unknown",
> -		"unknown",
> +		"3.90625 millseconds",
> +		"7.8215 milliseconds",
> +		"122.070 microseconds",
> +		"244.141 microseconds",
> +		"488.281 microseconds",
>   		"976.562 microseconds (default)",
> -		"unknown",
> -		"unknown",
> -		"unknown",
> -		"unknown",
> -		"unknown",
> -		"unknown",
> -		"unknown",
> -		"unknown",
> +		"1.953125 milliseconds",
> +		"3.90625 milliseconds",
> +		"7.8215 milliseconds",
> +		"15.625 milliseconds",
> +		"31.25 milliseconds",
> +		"62.5 milliseconds",
> +		"125 milliseconds",
> +		"250 milliseconds",
>   		"500 milliseconds"
>   	};
>
>
Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/cmos/cmosdump/cmosdump.c b/src/cmos/cmosdump/cmosdump.c
index 83923bf..7efb342 100644
--- a/src/cmos/cmosdump/cmosdump.c
+++ b/src/cmos/cmosdump/cmosdump.c
@@ -87,32 +87,32 @@  static int cmosdump_test1(fwts_framework *fw)
 	};
 
 	static char *divider[8] = {
-		"unknown",
-		"unknown",
+		"4.194 MHz",
+		"1.049 MHz",
 		"32.768 KHz (default)",
 		"unknown",
-		"unknown",
-		"unknown",
-		"unknown",
-		"unknown",
+		"test mode",
+		"test mode",
+		"reset / disable",
+		"reset / disable",
 	};
 
 	static char *rate_selection[16] = {
 		"none",
-		"unknown",
-		"unknown",
-		"122 microseconds (minimum)",
-		"unknown",
-		"unknown",
+		"3.90625 millseconds",
+		"7.8215 milliseconds",
+		"122.070 microseconds",
+		"244.141 microseconds",
+		"488.281 microseconds",
 		"976.562 microseconds (default)",
-		"unknown",
-		"unknown",
-		"unknown",
-		"unknown",
-		"unknown",
-		"unknown",
-		"unknown",
-		"unknown",
+		"1.953125 milliseconds",
+		"3.90625 milliseconds",
+		"7.8215 milliseconds",
+		"15.625 milliseconds",
+		"31.25 milliseconds",
+		"62.5 milliseconds",
+		"125 milliseconds",
+		"250 milliseconds",
 		"500 milliseconds"
 	};