From patchwork Wed Dec 12 23:19:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Jovanovic, Petar" X-Patchwork-Id: 205684 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4DBBA2C0091 for ; Thu, 13 Dec 2012 10:21:31 +1100 (EST) Received: from localhost ([::1]:39580 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TivcH-0006Sl-67 for incoming@patchwork.ozlabs.org; Wed, 12 Dec 2012 18:21:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tivc4-0006Kx-78 for qemu-devel@nongnu.org; Wed, 12 Dec 2012 18:21:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tivc0-0003OT-9o for qemu-devel@nongnu.org; Wed, 12 Dec 2012 18:21:16 -0500 Received: from dns1.mips.com ([12.201.5.69]:59482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tivbz-0003Nx-G7 for qemu-devel@nongnu.org; Wed, 12 Dec 2012 18:21:12 -0500 Received: from mailgate1.mips.com (mailgate1.mips.com [12.201.5.111]) by dns1.mips.com (8.13.8/8.13.8) with ESMTP id qBCNKRDK017685; Wed, 12 Dec 2012 15:20:27 -0800 X-WSS-ID: 0MEXY4Z-01-1HL-02 X-M-MSG: Received: from exchdb01.mips.com (unknown [192.168.36.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mailgate1.mips.com (Postfix) with ESMTP id 2E385364673; Wed, 12 Dec 2012 15:19:47 -0800 (PST) Received: from EXCHDB03.MIPS.com ([fe80::6df1:ae84:797e:9076]) by exchdb01.mips.com ([fe80::2897:a30d:a923:303%16]) with mapi id 14.01.0270.001; Wed, 12 Dec 2012 15:19:44 -0800 From: "Jovanovic, Petar" To: Dongxue Zhang , =?utf-8?B?QW5kcmVhcyBGw6RyYmVy?= Thread-Topic: [Qemu-devel] [PATCH 2/3] Make-repl_ph-to-sign-extended-to-target_long Thread-Index: AQHN17IUJIJCFJk3/0KXfEsqQ7J24ZgUdFyAgADKNgCAAI/XCg== Date: Wed, 12 Dec 2012 23:19:43 +0000 Message-ID: <874D219413C17C42B1D2E0432B92BE5CBBE29596@exchdb03.mips.com> References: <1355236110-4159-1-git-send-email-elta.era@gmail.com> <1355236110-4159-2-git-send-email-elta.era@gmail.com> <87hansfwqb.fsf@blackfin.pond.sub.org> <50C77DD3.6010205@suse.de>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.36.79] x-ems-proccessed: 6LP3oGfGVdcdb8o1aBnt6w== x-ems-stamp: 83whRgbWEjCSNV9h5TKAEg== MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 12.201.5.69 Cc: "aurelien@aurel32.net" , "rth@twiddle.net" , Markus Armbruster , =?utf-8?B?6Zmz6Z+L5Lu7?= , "qemu-devel@nongnu.org" Subject: Re: [Qemu-devel] [PATCH 2/3] Make-repl_ph-to-sign-extended-to-target_long X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org What does it mean you do not have gcc that can compile repl.ph instruction? How do you test your patches? If you want to append the repl_ph.c, you may want to add something like this: Petar p.s. +cc Aurelien J. ________________________________ From: Dongxue Zhang [elta.era@gmail.com] Sent: Wednesday, December 12, 2012 7:43 AM To: Andreas Färber Cc: Markus Armbruster; Jovanovic, Petar; qemu-devel@nongnu.org; 陳韋任; rth@twiddle.net Subject: Re: [Qemu-devel] [PATCH 2/3] Make-repl_ph-to-sign-extended-to-target_long Thanks for your review, now I know this problem but don't have gcc can compile repl_ph instruction. I will build a gcc and resend this patch later. 2012/12/12 Andreas Färber > Am 11.12.2012 16:13, schrieb Markus Armbruster: > Please-separate-words-with-spaces-in-your-subject-line-thank-you-:) Also all three patches should have a "target-mips: " prefix in the subject to make clear what they touch and who must review and later commit these. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg diff --git a/tests/tcg/mips/mips32-dsp/repl_ph.c b/tests/tcg/mips/mips32-dsp/repl_ph.c index 2107495..07d137d --- a/tests/tcg/mips/mips32-dsp/repl_ph.c +++ b/tests/tcg/mips/mips32-dsp/repl_ph.c @@ -19,5 +19,12 @@ int main() ); assert(rd == result); + result = 0xFFFFFFFF; + __asm + ("repl.ph %0, -1\n\t" + : "=r"(rd) + ); + assert(rd == result); + return 0; }