Patchwork apci: method: don't bother dumping out the _BIF contents

login
register
mail settings
Submitter Colin King
Date Dec. 12, 2012, 7:15 p.m.
Message ID <1355339723-2182-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/205627/
State Accepted
Headers show

Comments

Colin King - Dec. 12, 2012, 7:15 p.m.
From: Colin Ian King <colin.king@canonical.com>

Dumping the _BIF contents just clutters up the method test
output, so don't dump it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/method/method.c | 2 --
 1 file changed, 2 deletions(-)
Keng-Yu Lin - Dec. 18, 2012, 2:43 a.m.
On Thu, Dec 13, 2012 at 3:15 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Dumping the _BIF contents just clutters up the method test
> output, so don't dump it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/method/method.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 7831a92..a50809a 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -2427,8 +2427,6 @@ static void method_test_BIF_return(
>                 uint32_t i;
>                 int failed = 0;
>
> -               fwts_method_dump_object(fw, obj);
> -
>                 if (obj->Package.Count != 13) {
>                         fwts_failed(fw, LOG_LEVEL_MEDIUM,
>                                 "Method_BIFElementCount",
> --
> 1.8.0
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Dec. 20, 2012, 2:29 a.m.
On 12/13/2012 03:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Dumping the _BIF contents just clutters up the method test
> output, so don't dump it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/method/method.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 7831a92..a50809a 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -2427,8 +2427,6 @@ static void method_test_BIF_return(
>   		uint32_t i;
>   		int failed = 0;
>
> -		fwts_method_dump_object(fw, obj);
> -
>   		if (obj->Package.Count != 13) {
>   			fwts_failed(fw, LOG_LEVEL_MEDIUM,
>   				"Method_BIFElementCount",
>
Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index 7831a92..a50809a 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -2427,8 +2427,6 @@  static void method_test_BIF_return(
 		uint32_t i;
 		int failed = 0;
 
-		fwts_method_dump_object(fw, obj);
-
 		if (obj->Package.Count != 13) {
 			fwts_failed(fw, LOG_LEVEL_MEDIUM,
 				"Method_BIFElementCount",