Patchwork apci: method: don't bother dumping out the _BST contents

login
register
mail settings
Submitter Colin King
Date Dec. 12, 2012, 7:11 p.m.
Message ID <1355339517-1964-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/205626/
State Accepted
Headers show

Comments

Colin King - Dec. 12, 2012, 7:11 p.m.
From: Colin Ian King <colin.king@canonical.com>

Since we just want to sanity check the type of data being
returned and we can't gather _BST information from the EC we
shouldn't dump the package, it makes no sense and clutters up the
output.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/method/method.c | 2 --
 1 file changed, 2 deletions(-)
Keng-Yu Lin - Dec. 18, 2012, 2:42 a.m.
On Thu, Dec 13, 2012 at 3:11 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Since we just want to sanity check the type of data being
> returned and we can't gather _BST information from the EC we
> shouldn't dump the package, it makes no sense and clutters up the
> output.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/method/method.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 2dcbee0..7831a92 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -2750,8 +2750,6 @@ static void method_test_BST_return(
>                 uint32_t i;
>                 int failed = 0;
>
> -               fwts_method_dump_object(fw, obj);
> -
>                 if (obj->Package.Count != 4) {
>                         fwts_failed(fw, LOG_LEVEL_MEDIUM,
>                                 "Method_BSTElementCount",
> --
> 1.8.0
>
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Dec. 20, 2012, 2:29 a.m.
On 12/13/2012 03:11 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Since we just want to sanity check the type of data being
> returned and we can't gather _BST information from the EC we
> shouldn't dump the package, it makes no sense and clutters up the
> output.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/method/method.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 2dcbee0..7831a92 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -2750,8 +2750,6 @@ static void method_test_BST_return(
>   		uint32_t i;
>   		int failed = 0;
>
> -		fwts_method_dump_object(fw, obj);
> -
>   		if (obj->Package.Count != 4) {
>   			fwts_failed(fw, LOG_LEVEL_MEDIUM,
>   				"Method_BSTElementCount",
>
Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index 2dcbee0..7831a92 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -2750,8 +2750,6 @@  static void method_test_BST_return(
 		uint32_t i;
 		int failed = 0;
 
-		fwts_method_dump_object(fw, obj);
-
 		if (obj->Package.Count != 4) {
 			fwts_failed(fw, LOG_LEVEL_MEDIUM,
 				"Method_BSTElementCount",