From patchwork Wed Dec 12 18:35:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 205605 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id E8A0B2C0091 for ; Thu, 13 Dec 2012 05:35:21 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1Tir9M-0003wl-QA; Wed, 12 Dec 2012 18:35:20 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1Tir9K-0003wb-O1 for fwts-devel@lists.ubuntu.com; Wed, 12 Dec 2012 18:35:18 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1Tir9K-0002W2-Lm for fwts-devel@lists.ubuntu.com; Wed, 12 Dec 2012 18:35:18 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: method: don't bother reporting internal ACPI lock success Date: Wed, 12 Dec 2012 18:35:18 +0000 Message-Id: <1355337318-30030-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Each object that gets evaluated has a sanity check to see if the internal locking state is sane. This rarely goes wrong, so ingore reporting success as this adds to the noise on the output. Just report failures. Signed-off-by: Colin Ian King Acked-by: Keng-Yu Lin Acked-by: Ivan Hu --- src/acpi/method/method.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c index 3ec7836..52b0e18 100644 --- a/src/acpi/method/method.c +++ b/src/acpi/method/method.c @@ -342,8 +342,7 @@ static void method_evaluate_found_method( if (ACPI_FAILURE(ret) != AE_OK) { fwts_method_evaluate_report_error(fw, name, ret); - } - else { + } else { if (check_func != NULL) { ACPI_OBJECT *obj = buf.Pointer; check_func(fw, name, &buf, obj, private); @@ -366,12 +365,7 @@ static void method_evaluate_found_method( "acquired lock. It may be occurring in the method " "being tested or other methods used while evaluating " "the method."); - } else - if ((sem_acquired + sem_released) > 0) - fwts_passed(fw, - "%s correctly acquired and released locks " - "%d times.", name, sem_acquired); - + } } /*