| Submitter | Colin King |
|---|---|
| Date | Dec. 12, 2012, 6:31 p.m. |
| Message ID | <1355337082-29753-1-git-send-email-colin.king@canonical.com> |
| Download | mbox | patch |
| Permalink | /patch/205603/ |
| State | Accepted |
| Headers | show |
Comments
On Thu, Dec 13, 2012 at 2:31 AM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Since we don't care about the contents returned by _WAK we may > as well not dump the entire package returned when evaluating it. > This removes a lot of unnecessary noise from the test results. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpi/method/method.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c > index be274b9..3ec7836 100644 > --- a/src/acpi/method/method.c > +++ b/src/acpi/method/method.c > @@ -3419,8 +3419,6 @@ static void method_test_WAK_return( > FWTS_UNUSED(private); > > if (method_check_type(fw, name, buf, ACPI_TYPE_PACKAGE) == FWTS_OK) { > - fwts_method_dump_object(fw, obj); > - > if (obj->Package.Count != 2) { > fwts_failed(fw, LOG_LEVEL_MEDIUM, > "Method_WAKElementCount", > -- > 1.8.0 > Acked-by: Keng-Yu Lin <kengyu@canonical.com>
On 12/13/2012 02:31 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Since we don't care about the contents returned by _WAK we may > as well not dump the entire package returned when evaluating it. > This removes a lot of unnecessary noise from the test results. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpi/method/method.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c > index be274b9..3ec7836 100644 > --- a/src/acpi/method/method.c > +++ b/src/acpi/method/method.c > @@ -3419,8 +3419,6 @@ static void method_test_WAK_return( > FWTS_UNUSED(private); > > if (method_check_type(fw, name, buf, ACPI_TYPE_PACKAGE) == FWTS_OK) { > - fwts_method_dump_object(fw, obj); > - > if (obj->Package.Count != 2) { > fwts_failed(fw, LOG_LEVEL_MEDIUM, > "Method_WAKElementCount", > Acked-by: Ivan Hu <ivan.hu@canonical.com>
Patch
diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c index be274b9..3ec7836 100644 --- a/src/acpi/method/method.c +++ b/src/acpi/method/method.c @@ -3419,8 +3419,6 @@ static void method_test_WAK_return( FWTS_UNUSED(private); if (method_check_type(fw, name, buf, ACPI_TYPE_PACKAGE) == FWTS_OK) { - fwts_method_dump_object(fw, obj); - if (obj->Package.Count != 2) { fwts_failed(fw, LOG_LEVEL_MEDIUM, "Method_WAKElementCount",