| Message ID | 8c901014a0f571011023ed98b9a22bc690925b73.1355335228.git.joe@perches.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Benjamin Herrenschmidt |
| Headers | show |
On Wednesday 12 December 2012, Joe Perches wrote: > Use the new vsprintf extension to avoid any possible > message interleaving. > > Convert the #ifdef DEBUG block to a single pr_debug. > > Signed-off-by: Joe Perches <joe@perches.com> nice cleanup! Acked-by: Arnd Bergmann <arnd@arndb.de>
On Thu, 2012-12-13 at 11:58 +0000, Arnd Bergmann wrote: > On Wednesday 12 December 2012, Joe Perches wrote: > > Use the new vsprintf extension to avoid any possible > > message interleaving. > > > > Convert the #ifdef DEBUG block to a single pr_debug. > > > > Signed-off-by: Joe Perches <joe@perches.com> > > nice cleanup! ... which also breaks the build :-( > Acked-by: Arnd Bergmann <arnd@arndb.de> I'll fix it up locally. Ben. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
On Thu, 2013-01-10 at 16:48 +1100, Benjamin Herrenschmidt wrote: > On Thu, 2012-12-13 at 11:58 +0000, Arnd Bergmann wrote: > > On Wednesday 12 December 2012, Joe Perches wrote: > > > Use the new vsprintf extension to avoid any possible > > > message interleaving. > > > > > > Convert the #ifdef DEBUG block to a single pr_debug. > > > > > > Signed-off-by: Joe Perches <joe@perches.com> > > > > nice cleanup! > > ... which also breaks the build :-( > > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > I'll fix it up locally. OK, I didn't compile it. How does it break the build?
diff --git a/arch/powerpc/platforms/cell/spu_callbacks.c b/arch/powerpc/platforms/cell/spu_callbacks.c index 75d6133..c5fe6d2 100644 --- a/arch/powerpc/platforms/cell/spu_callbacks.c +++ b/arch/powerpc/platforms/cell/spu_callbacks.c @@ -60,13 +60,11 @@ long spu_sys_callback(struct spu_syscall_block *s) syscall = spu_syscall_table[s->nr_ret]; -#ifdef DEBUG - print_symbol(KERN_DEBUG "SPU-syscall %s:", (unsigned long)syscall); - printk("syscall%ld(%lx, %lx, %lx, %lx, %lx, %lx)\n", - s->nr_ret, - s->parm[0], s->parm[1], s->parm[2], - s->parm[3], s->parm[4], s->parm[5]); -#endif + pr_debug("SPU-syscall %pSR:syscall%ld(%lx, %lx, %lx, %lx, %lx, %lx)\n", + syscall, + s->nr_ret, + s->parm[0], s->parm[1], s->parm[2], + s->parm[3], s->parm[4], s->parm[5]); return syscall(s->parm[0], s->parm[1], s->parm[2], s->parm[3], s->parm[4], s->parm[5]);
Use the new vsprintf extension to avoid any possible message interleaving. Convert the #ifdef DEBUG block to a single pr_debug. Signed-off-by: Joe Perches <joe@perches.com> --- arch/powerpc/platforms/cell/spu_callbacks.c | 12 +++++------- 1 files changed, 5 insertions(+), 7 deletions(-)