From patchwork Tue Dec 11 21:49:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Tosatti X-Patchwork-Id: 205310 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B6AED2C008A for ; Wed, 12 Dec 2012 08:50:45 +1100 (EST) Received: from localhost ([::1]:46777 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiXit-0000Fe-VW for incoming@patchwork.ozlabs.org; Tue, 11 Dec 2012 16:50:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiXim-0000FI-U1 for qemu-devel@nongnu.org; Tue, 11 Dec 2012 16:50:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiXil-0006QL-Bt for qemu-devel@nongnu.org; Tue, 11 Dec 2012 16:50:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiXil-0006QD-52 for qemu-devel@nongnu.org; Tue, 11 Dec 2012 16:50:35 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBBLoXX8004373 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 11 Dec 2012 16:50:33 -0500 Received: from amt.cnet (vpn1-5-254.gru2.redhat.com [10.97.5.254]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBBLoQFo032540; Tue, 11 Dec 2012 16:50:32 -0500 Received: from amt.cnet (amt.cnet [127.0.0.1]) by amt.cnet (Postfix) with ESMTP id 63E1968A32E; Tue, 11 Dec 2012 19:49:19 -0200 (BRST) Received: (from marcelo@localhost) by amt.cnet (8.14.5/8.14.5/Submit) id qBBLnHaQ003962; Tue, 11 Dec 2012 19:49:17 -0200 Date: Tue, 11 Dec 2012 19:49:17 -0200 From: Marcelo Tosatti To: Jan Kiszka , qemu-devel@nongnu.org Message-ID: <20121211214916.GA3871@amt.cnet> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] RTC: enable lost_tick_policy=slew as default X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org RTC interrupt reinjection has no known negative effect. Lack of RTC interrupt reinjection, though, has negative effects: time drift for Windows guests which use it as a timer source. Based on that, enable lost_tick_policy=slew option as default. Signed-off-by: Marcelo Tosatti diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index c79fca7..c9e007d 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @@ -884,7 +884,7 @@ ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq) static Property mc146818rtc_properties[] = { DEFINE_PROP_INT32("base_year", RTCState, base_year, 1980), DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState, - lost_tick_policy, LOST_TICK_DISCARD), + lost_tick_policy, LOST_TICK_SLEW), DEFINE_PROP_END_OF_LIST(), };