Patchwork [2/4,RESEND] iio: Add Usage IDs for HID time sensors.

login
register
mail settings
Submitter Alexander Holler
Date Dec. 11, 2012, 6:21 p.m.
Message ID <1355250106-3114-2-git-send-email-holler@ahsoftware.de>
Download mbox | patch
Permalink /patch/205283/
State New
Headers show

Comments

Alexander Holler - Dec. 11, 2012, 6:21 p.m.
These are Usage IDs for the attributes year, month, day,
hour, minute and second, needed to read HID time sensors.

Signed-off-by: Alexander Holler <holler@ahsoftware.de>
---
 include/linux/hid-sensor-ids.h |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
Jonathan Cameron - Dec. 15, 2012, 11:06 a.m.
On 12/11/2012 06:21 PM, Alexander Holler wrote:
> These are Usage IDs for the attributes year, month, day,
> hour, minute and second, needed to read HID time sensors.
> 
> Signed-off-by: Alexander Holler <holler@ahsoftware.de>
This has gotten very messy to follow.  Could you resend the
patches (without the first) with Jiri cc'd as well
(as some of this is in his domain as HID maintainer).

Given this makes quite a few changes in IIO drivers I'm happy
to take the lot through the IIO tree but to do that I would
like a go ahead from Jiri + either Andrew or Alessandro
(for rtc side of things).

Alexander, you need to be careful with multi subsystem patches
like these to ensure everyone relevant is in the cc list.


> ---
>  include/linux/hid-sensor-ids.h |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-sensor-ids.h
> index ca8d7e9..3754ea9 100644
> --- a/include/linux/hid-sensor-ids.h
> +++ b/include/linux/hid-sensor-ids.h
> @@ -67,6 +67,15 @@
>  #define HID_USAGE_SENSOR_ORIENT_MAGN_FLUX_Y_AXIS		0x200486
>  #define HID_USAGE_SENSOR_ORIENT_MAGN_FLUX_Z_AXIS		0x200487
>  
> +/* Time (2000a0) */
> +#define HID_USAGE_SENSOR_TIME					0x2000a0
> +#define HID_USAGE_SENSOR_TIME_YEAR				0x200521
> +#define HID_USAGE_SENSOR_TIME_MONTH				0x200522
> +#define HID_USAGE_SENSOR_TIME_DAY				0x200523
> +#define HID_USAGE_SENSOR_TIME_HOUR				0x200525
> +#define HID_USAGE_SENSOR_TIME_MINUTE				0x200526
> +#define HID_USAGE_SENSOR_TIME_SECOND				0x200527
> +
>  /* Units */
>  #define HID_USAGE_SENSOR_UNITS_NOT_SPECIFIED			0x00
>  #define HID_USAGE_SENSOR_UNITS_LUX				0x01
>
Alexander Holler - Dec. 15, 2012, 12:41 p.m.
Am 15.12.2012 12:06, schrieb Jonathan Cameron:
> On 12/11/2012 06:21 PM, Alexander Holler wrote:
>> These are Usage IDs for the attributes year, month, day,
>> hour, minute and second, needed to read HID time sensors.
>>
>> Signed-off-by: Alexander Holler <holler@ahsoftware.de>
> This has gotten very messy to follow.  Could you resend the

I aggree. The workflow (ping-pong until a patch is almost perfect, 
without typos and style glitches and makes the maintainers eyes happy) 
is horrible and requires quite a lot goodwill and patience on every 
side. Not the stuff people like to do on a voluntarily basis.

So thanks to everyone who still follows.

The whole series (now 5 patches) follows. I mark all of them as RESEND 
to indicate that no changes were done since I've send them the last time.

> patches (without the first) with Jiri cc'd as well
> (as some of this is in his domain as HID maintainer).

Sorry, almost the whole series (5-1 = 4) follows. ;)

>
> Given this makes quite a few changes in IIO drivers I'm happy
> to take the lot through the IIO tree but to do that I would
> like a go ahead from Jiri + either Andrew or Alessandro
> (for rtc side of things).

Thanks again.

Alexander

Patch

diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-sensor-ids.h
index ca8d7e9..3754ea9 100644
--- a/include/linux/hid-sensor-ids.h
+++ b/include/linux/hid-sensor-ids.h
@@ -67,6 +67,15 @@ 
 #define HID_USAGE_SENSOR_ORIENT_MAGN_FLUX_Y_AXIS		0x200486
 #define HID_USAGE_SENSOR_ORIENT_MAGN_FLUX_Z_AXIS		0x200487
 
+/* Time (2000a0) */
+#define HID_USAGE_SENSOR_TIME					0x2000a0
+#define HID_USAGE_SENSOR_TIME_YEAR				0x200521
+#define HID_USAGE_SENSOR_TIME_MONTH				0x200522
+#define HID_USAGE_SENSOR_TIME_DAY				0x200523
+#define HID_USAGE_SENSOR_TIME_HOUR				0x200525
+#define HID_USAGE_SENSOR_TIME_MINUTE				0x200526
+#define HID_USAGE_SENSOR_TIME_SECOND				0x200527
+
 /* Units */
 #define HID_USAGE_SENSOR_UNITS_NOT_SPECIFIED			0x00
 #define HID_USAGE_SENSOR_UNITS_LUX				0x01