Patchwork iproute2: ss - change default filter to include all socket types

login
register
mail settings
Submitter Petr Sabata
Date Dec. 11, 2012, 4:42 p.m.
Message ID <1355244172-32071-1-git-send-email-contyk@redhat.com>
Download mbox | patch
Permalink /patch/205272/
State Accepted
Delegated to: stephen hemminger
Headers show

Comments

Petr Sabata - Dec. 11, 2012, 4:42 p.m.
Currently the default filter lists TCP sockets only which is
rather confusing especially when the '-a/--all' flag is used.
This patch changes the default to include all sockets, imitating
netstat(8) behavior.

Signed-off-by: Petr Šabata <contyk@redhat.com>
---
 misc/ss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - Dec. 11, 2012, 5:45 p.m.
From: Petr Šabata <contyk@redhat.com>
Date: Tue, 11 Dec 2012 17:42:52 +0100

> Currently the default filter lists TCP sockets only which is
> rather confusing especially when the '-a/--all' flag is used.
> This patch changes the default to include all sockets, imitating
> netstat(8) behavior.
> 
> Signed-off-by: Petr Šabata <contyk@redhat.com>

Acked-by: David S. Miller <davem@davemloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/misc/ss.c b/misc/ss.c
index b45f5ba..b8cd60d 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -105,7 +105,7 @@  struct filter
 };
 
 struct filter default_filter = {
-	.dbs	=  (1<<TCP_DB),
+	.dbs	=  ~0,
 	.states = SS_ALL & ~((1<<SS_LISTEN)|(1<<SS_CLOSE)|(1<<SS_TIME_WAIT)|(1<<SS_SYN_RECV)),
 	.families= (1<<AF_INET)|(1<<AF_INET6),
 };