Patchwork [U-Boot] woodburn: Set gpio value in gpio_direction_output()

login
register
mail settings
Submitter Fabio Estevam
Date Dec. 11, 2012, 4:19 p.m.
Message ID <1355242795-16606-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/205271/
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Dec. 11, 2012, 4:19 p.m.
Set the gpio value in gpio_direction_output() instead of an extra gpio_set_value
call.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/woodburn/woodburn.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Stefano Babic - Dec. 11, 2012, 4:38 p.m.
On 11/12/2012 17:19, Fabio Estevam wrote:
> Set the gpio value in gpio_direction_output() instead of an extra gpio_set_value
> call.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/woodburn/woodburn.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/board/woodburn/woodburn.c b/board/woodburn/woodburn.c
> index 66a0d35..d74f360 100644
> --- a/board/woodburn/woodburn.c
> +++ b/board/woodburn/woodburn.c
> @@ -133,8 +133,7 @@ int woodburn_init(void)
>  	mxc_request_iomux(MX35_PIN_SCKR, MUX_CONFIG_ALT5);
>  	gpio_direction_output(4, 1);
>  	mxc_request_iomux(MX35_PIN_HCKT, MUX_CONFIG_ALT5);
> -	gpio_direction_output(9, 0);
> -	gpio_set_value(9, 1);
> +	gpio_direction_output(9, 1);
>  
>  	return 0;
>  }
> 

Thanks !

Acked-by: Stefano Babic <sbabic@denx.de>

Regards,
Stefano
Stefano Babic - Dec. 11, 2012, 4:45 p.m.
On 11/12/2012 17:19, Fabio Estevam wrote:
> Set the gpio value in gpio_direction_output() instead of an extra gpio_set_value
> call.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/woodburn/woodburn.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/board/woodburn/woodburn.c b/board/woodburn/woodburn.c
> index 66a0d35..d74f360 100644
> --- a/board/woodburn/woodburn.c
> +++ b/board/woodburn/woodburn.c
> @@ -133,8 +133,7 @@ int woodburn_init(void)
>  	mxc_request_iomux(MX35_PIN_SCKR, MUX_CONFIG_ALT5);
>  	gpio_direction_output(4, 1);
>  	mxc_request_iomux(MX35_PIN_HCKT, MUX_CONFIG_ALT5);
> -	gpio_direction_output(9, 0);
> -	gpio_set_value(9, 1);
> +	gpio_direction_output(9, 1);
>  
>  	return 0;
>  }
> 
Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/board/woodburn/woodburn.c b/board/woodburn/woodburn.c
index 66a0d35..d74f360 100644
--- a/board/woodburn/woodburn.c
+++ b/board/woodburn/woodburn.c
@@ -133,8 +133,7 @@  int woodburn_init(void)
 	mxc_request_iomux(MX35_PIN_SCKR, MUX_CONFIG_ALT5);
 	gpio_direction_output(4, 1);
 	mxc_request_iomux(MX35_PIN_HCKT, MUX_CONFIG_ALT5);
-	gpio_direction_output(9, 0);
-	gpio_set_value(9, 1);
+	gpio_direction_output(9, 1);
 
 	return 0;
 }