Patchwork [1/3] Fix my email address

login
register
mail settings
Submitter Dongxue Zhang
Date Dec. 11, 2012, 2:28 p.m.
Message ID <1355236110-4159-1-git-send-email-elta.era@gmail.com>
Download mbox | patch
Permalink /patch/205245/
State New
Headers show

Comments

Dongxue Zhang - Dec. 11, 2012, 2:28 p.m.
Fix my email address, last time it's wrong.

Signed-off-by: Dongxue Zhang <elta.era@gmail.com>
---
 target-mips/dsp_helper.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Stefan Weil - Dec. 11, 2012, 5:25 p.m.
Am 11.12.2012 15:28, schrieb Dongxue Zhang:
> Fix my email address, last time it's wrong.
>
> Signed-off-by: Dongxue Zhang <elta.era@gmail.com>
> ---
>   target-mips/dsp_helper.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
> index 14daf91..536032b 100644
> --- a/target-mips/dsp_helper.c
> +++ b/target-mips/dsp_helper.c
> @@ -2,7 +2,7 @@
>    * MIPS ASE DSP Instruction emulation helpers for QEMU.
>    *
>    * Copyright (c) 2012  Jia Liu <proljc@gmail.com>
> - *                     Dongxue Zhang <elat.era@gmail.com>
> + *                     Dongxue Zhang <elta.era@gmail.com>
>    * This library is free software; you can redistribute it and/or
>    * modify it under the terms of the GNU Lesser General Public
>    * License as published by the Free Software Foundation; either


Maybe removing the email address completely would be even
better. There is already an email address in eachcommit,
some addresses are in file MAINTAINERS, and you can also
add a personal entry in the QEMU wiki (linked to this URL:
http://wiki.qemu.org/Contribute/StartHere#Developers_and_Maintainers).

Currently there are copyright statements with and without
email address. I personally prefer those without, especially
when email address are known to be volatile. Even email
addresses at redhat.com (or other companies) are only valid
as long as the owner is related to RedHat.

Regards
Stefan Weil
Stefan Weil - Dec. 12, 2012, 10:02 p.m.
Am 12.12.2012 08:24, schrieb Dongxue Zhang:
>
> Sorry I don't really catch your idea. This email address is wrong and 
> i just
> want to correct it. I just want to do something to qemu. When I add
> target-mips/dsp_helper.c I got lots of help from other people, so I 
> also want to
> help others who need help from me. But with a wrong email, they send 
> mail to me
> will never get reply, this will make me looks like a cold guy, It's 
> not what I
> want. So I want to correct my email address. :)

Of course fixing a wrong email address is better than keeping a wrong 
address
in the code. But will you also fix the address when you change it some day,
maybe years later? What about old versions of QEMU? They will still show an
old email address. Most email addresses have a limit life time.

That's why I think that _no_ email address in source code might be better.
It is still possible to find authors by looking at the Signed-off-by in the
commit message or by searching the QEMU wiki or other sources of 
information.

Stefan Weil


>
>
> 2012/12/12 Stefan Weil <sw@weilnetz.de <mailto:sw@weilnetz.de>>
>
>     Am 11.12.2012 15:28, schrieb Dongxue Zhang:
>
>         Fix my email address, last time it's wrong.
>
>         Signed-off-by: Dongxue Zhang <elta.era@gmail.com
>         <mailto:elta.era@gmail.com>>
>         ---
>           target-mips/dsp_helper.c |    2 +-
>           1 file changed, 1 insertion(+), 1 deletion(-)
>
>         diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
>         index 14daf91..536032b 100644
>         --- a/target-mips/dsp_helper.c
>         +++ b/target-mips/dsp_helper.c
>         @@ -2,7 +2,7 @@
>            * MIPS ASE DSP Instruction emulation helpers for QEMU.
>            *
>            * Copyright (c) 2012  Jia Liu <proljc@gmail.com
>         <mailto:proljc@gmail.com>>
>         - *                     Dongxue Zhang <elat.era@gmail.com
>         <mailto:elat.era@gmail.com>>
>         + *                     Dongxue Zhang <elta.era@gmail.com
>         <mailto:elta.era@gmail.com>>
>            * This library is free software; you can redistribute it and/or
>            * modify it under the terms of the GNU Lesser General Public
>            * License as published by the Free Software Foundation; either
>
>
>
>     Maybe removing the email address completely would be even
>     better. There is already an email address in eachcommit,
>     some addresses are in file MAINTAINERS, and you can also
>     add a personal entry in the QEMU wiki (linked to this URL:
>     http://wiki.qemu.org/Contribute/StartHere#Developers_and_Maintainers).
>
>     Currently there are copyright statements with and without
>     email address. I personally prefer those without, especially
>     when email address are known to be volatile. Even email
>     addresses at redhat.com <http://redhat.com> (or other companies)
>     are only valid
>     as long as the owner is related to RedHat.
>
>     Regards
>     Stefan Weil
>
>
>
陳韋任 - Dec. 13, 2012, 7 a.m.
On Wed, Dec 12, 2012 at 11:02:59PM +0100, Stefan Weil wrote:
> Am 12.12.2012 08:24, schrieb Dongxue Zhang:
> 
> 
>     Sorry I don't really catch your idea. This email address is wrong and i
>     just
>     want to correct it. I just want to do something to qemu. When I add
>     target-mips/dsp_helper.c I got lots of help from other people, so I also
>     want to
>     help others who need help from me. But with a wrong email, they send mail
>     to me
>     will never get reply, this will make me looks like a cold guy, It's not
>     what I
>     want. So I want to correct my email address. :)
> 
> 
> Of course fixing a wrong email address is better than keeping a wrong address
> in the code. But will you also fix the address when you change it some day,
> maybe years later? What about old versions of QEMU? They will still show an
> old email address. Most email addresses have a limit life time.

  Well... Just let him fix his mail address (he want it in the source
code). Maybe we can discuss if we want the mail address in the code
while reviewing new coming patch next time. ;)

Regards,
chenwj

Patch

diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
index 14daf91..536032b 100644
--- a/target-mips/dsp_helper.c
+++ b/target-mips/dsp_helper.c
@@ -2,7 +2,7 @@ 
  * MIPS ASE DSP Instruction emulation helpers for QEMU.
  *
  * Copyright (c) 2012  Jia Liu <proljc@gmail.com>
- *                     Dongxue Zhang <elat.era@gmail.com>
+ *                     Dongxue Zhang <elta.era@gmail.com>
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either