Patchwork ide/net: flip the order of SATA and network init

login
register
mail settings
Submitter Arjan van de Ven
Date Jan. 27, 2009, 10:19 p.m.
Message ID <20090127141952.51785b4f@infradead.org>
Download mbox | patch
Permalink /patch/20524/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Arjan van de Ven - Jan. 27, 2009, 10:19 p.m.
From e89d6840ad685a3c61f72367d4ac5bfed69ead0c Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@linux.intel.com>
Date: Mon, 26 Jan 2009 18:58:11 -0800
Subject: [PATCH] ide/net: flip the order of SATA and network init

this patch flips the order in which sata and network drivers are initialized.

SATA probing takes quite a bit of time, and with the asynchronous infrastructure
other drivers that run after it can execute in parallel. Network drivers do tend
to take some real time talking to the hardware, so running these later is
a good thing (the sata probe then runs concurrent)

This saves about 15% of my kernels boot time.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
 drivers/Makefile |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
David Miller - Jan. 27, 2009, 10:26 p.m.
From: Arjan van de Ven <arjan@infradead.org>
Date: Tue, 27 Jan 2009 14:19:52 -0800

> ide/net: flip the order of SATA and network init
> 
> this patch flips the order in which sata and network drivers are initialized.
> 
> SATA probing takes quite a bit of time, and with the asynchronous infrastructure
> other drivers that run after it can execute in parallel. Network drivers do tend
> to take some real time talking to the hardware, so running these later is
> a good thing (the sata probe then runs concurrent)
> 
> This saves about 15% of my kernels boot time.
> 
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>

I have no problem with this:

Acked-by: David S. Miller <davem@davemloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Garzik - Jan. 27, 2009, 11:35 p.m.
Arjan van de Ven wrote:
>>From e89d6840ad685a3c61f72367d4ac5bfed69ead0c Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@linux.intel.com>
> Date: Mon, 26 Jan 2009 18:58:11 -0800
> Subject: [PATCH] ide/net: flip the order of SATA and network init
> 
> this patch flips the order in which sata and network drivers are initialized.
> 
> SATA probing takes quite a bit of time, and with the asynchronous infrastructure
> other drivers that run after it can execute in parallel. Network drivers do tend
> to take some real time talking to the hardware, so running these later is
> a good thing (the sata probe then runs concurrent)
> 
> This saves about 15% of my kernels boot time.
> 
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
> ---
>  drivers/Makefile |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/Makefile b/drivers/Makefile
> index c1bf417..2618a61 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -36,13 +36,14 @@ obj-$(CONFIG_FB_INTEL)          += video/intelfb/
>  
>  obj-y				+= serial/
>  obj-$(CONFIG_PARPORT)		+= parport/
> -obj-y				+= base/ block/ misc/ mfd/ net/ media/
> +obj-y				+= base/ block/ misc/ mfd/ media/
>  obj-$(CONFIG_NUBUS)		+= nubus/
> -obj-$(CONFIG_ATM)		+= atm/
>  obj-y				+= macintosh/
>  obj-$(CONFIG_IDE)		+= ide/
>  obj-$(CONFIG_SCSI)		+= scsi/
>  obj-$(CONFIG_ATA)		+= ata/
> +obj-y				+= net/
> +obj-$(CONFIG_ATM)		+= atm/
>  obj-$(CONFIG_FUSION)		+= message/
>  obj-$(CONFIG_FIREWIRE)		+= firewire/
>  obj-y				+= ieee1394/

ACK, ok with me too

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bartlomiej Zolnierkiewicz - Jan. 28, 2009, 12:22 a.m.
On Tuesday 27 January 2009, Arjan van de Ven wrote:
> From e89d6840ad685a3c61f72367d4ac5bfed69ead0c Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@linux.intel.com>
> Date: Mon, 26 Jan 2009 18:58:11 -0800
> Subject: [PATCH] ide/net: flip the order of SATA and network init
> 
> this patch flips the order in which sata and network drivers are initialized.

it seems to affect much more than that, please see below

> SATA probing takes quite a bit of time, and with the asynchronous infrastructure
> other drivers that run after it can execute in parallel. Network drivers do tend
> to take some real time talking to the hardware, so running these later is
> a good thing (the sata probe then runs concurrent)
> 
> This saves about 15% of my kernels boot time.
> 
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
> ---
>  drivers/Makefile |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/Makefile b/drivers/Makefile
> index c1bf417..2618a61 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -36,13 +36,14 @@ obj-$(CONFIG_FB_INTEL)          += video/intelfb/
>  
>  obj-y				+= serial/
>  obj-$(CONFIG_PARPORT)		+= parport/
> -obj-y				+= base/ block/ misc/ mfd/ net/ media/
> +obj-y				+= base/ block/ misc/ mfd/ media/
>  obj-$(CONFIG_NUBUS)		+= nubus/
> -obj-$(CONFIG_ATM)		+= atm/
>  obj-y				+= macintosh/
>  obj-$(CONFIG_IDE)		+= ide/
>  obj-$(CONFIG_SCSI)		+= scsi/

scsi, ide, macintosh and nubus will be now init-ed after network.

No problem for ide but I'm not really sure about scsi...

>  obj-$(CONFIG_ATA)		+= ata/
> +obj-y				+= net/
> +obj-$(CONFIG_ATM)		+= atm/
>  obj-$(CONFIG_FUSION)		+= message/
>  obj-$(CONFIG_FIREWIRE)		+= firewire/
>  obj-y				+= ieee1394/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Arjan van de Ven - Jan. 28, 2009, 12:48 a.m.
On Tue, 27 Jan 2009 18:35:37 -0500
Jeff Garzik <jeff@garzik.org> wrote:

> ACK, ok with me too
> 

ok so... which tree should this go via?

I would guess jgarzik's because he deals with both sata and net ;)

Jeff... how do you want to handle this?
David Miller - Jan. 28, 2009, 1:23 a.m.
From: Arjan van de Ven <arjan@infradead.org>
Date: Tue, 27 Jan 2009 16:48:42 -0800

> On Tue, 27 Jan 2009 18:35:37 -0500
> Jeff Garzik <jeff@garzik.org> wrote:
> 
> > ACK, ok with me too
> > 
> 
> ok so... which tree should this go via?

Feel free to just submit it directly to Linus, you have both
of our ACKs :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Garzik - Jan. 28, 2009, 1:59 a.m.
David Miller wrote:
> From: Arjan van de Ven <arjan@infradead.org>
> Date: Tue, 27 Jan 2009 16:48:42 -0800
> 
>> On Tue, 27 Jan 2009 18:35:37 -0500
>> Jeff Garzik <jeff@garzik.org> wrote:
>>
>>> ACK, ok with me too
>>>
>> ok so... which tree should this go via?
> 
> Feel free to just submit it directly to Linus, you have both
> of our ACKs :-)

ACK :)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/Makefile b/drivers/Makefile
index c1bf417..2618a61 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -36,13 +36,14 @@  obj-$(CONFIG_FB_INTEL)          += video/intelfb/
 
 obj-y				+= serial/
 obj-$(CONFIG_PARPORT)		+= parport/
-obj-y				+= base/ block/ misc/ mfd/ net/ media/
+obj-y				+= base/ block/ misc/ mfd/ media/
 obj-$(CONFIG_NUBUS)		+= nubus/
-obj-$(CONFIG_ATM)		+= atm/
 obj-y				+= macintosh/
 obj-$(CONFIG_IDE)		+= ide/
 obj-$(CONFIG_SCSI)		+= scsi/
 obj-$(CONFIG_ATA)		+= ata/
+obj-y				+= net/
+obj-$(CONFIG_ATM)		+= atm/
 obj-$(CONFIG_FUSION)		+= message/
 obj-$(CONFIG_FIREWIRE)		+= firewire/
 obj-y				+= ieee1394/