Patchwork [2/4] lib: Makefile: Link in math library because we need sqrt()

login
register
mail settings
Submitter Colin King
Date Dec. 11, 2012, 12:04 p.m.
Message ID <1355227446-14380-3-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/205186/
State Accepted
Headers show

Comments

Colin King - Dec. 11, 2012, 12:04 p.m.
From: Colin Ian King <colin.king@canonical.com>

The new fwts_cpu_performance() requires the math library.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Keng-Yu Lin - Dec. 18, 2012, 2:23 a.m.
On Tue, Dec 11, 2012 at 8:04 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The new fwts_cpu_performance() requires the math library.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/Makefile.am b/src/lib/src/Makefile.am
> index 288ecad..2ef73b0 100644
> --- a/src/lib/src/Makefile.am
> +++ b/src/lib/src/Makefile.am
> @@ -5,7 +5,7 @@ AM_CPPFLAGS = \
>         -Wall -Werror -Wextra
>
>  pkglib_LTLIBRARIES = libfwts.la
> -libfwts_la_LDFLAGS = -lpcre -lpthread -ljson -version-info 1:0:0 \
> +libfwts_la_LDFLAGS = -lm -lpcre -lpthread -ljson -version-info 1:0:0 \
>         -L$(top_srcdir)/src/acpica/source/compiler -lfwtsiasl
>
>  libfwts_la_SOURCES = \
> --
> 1.8.0
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Dec. 19, 2012, 7:55 a.m.
On 12/11/2012 08:04 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The new fwts_cpu_performance() requires the math library.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/src/Makefile.am | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/Makefile.am b/src/lib/src/Makefile.am
> index 288ecad..2ef73b0 100644
> --- a/src/lib/src/Makefile.am
> +++ b/src/lib/src/Makefile.am
> @@ -5,7 +5,7 @@ AM_CPPFLAGS = \
>   	-Wall -Werror -Wextra
>
>   pkglib_LTLIBRARIES = libfwts.la
> -libfwts_la_LDFLAGS = -lpcre -lpthread -ljson -version-info 1:0:0 \
> +libfwts_la_LDFLAGS = -lm -lpcre -lpthread -ljson -version-info 1:0:0 \
>   	-L$(top_srcdir)/src/acpica/source/compiler -lfwtsiasl
>
>   libfwts_la_SOURCES = \
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/lib/src/Makefile.am b/src/lib/src/Makefile.am
index 288ecad..2ef73b0 100644
--- a/src/lib/src/Makefile.am
+++ b/src/lib/src/Makefile.am
@@ -5,7 +5,7 @@  AM_CPPFLAGS = \
 	-Wall -Werror -Wextra
 
 pkglib_LTLIBRARIES = libfwts.la
-libfwts_la_LDFLAGS = -lpcre -lpthread -ljson -version-info 1:0:0 \
+libfwts_la_LDFLAGS = -lm -lpcre -lpthread -ljson -version-info 1:0:0 \
 	-L$(top_srcdir)/src/acpica/source/compiler -lfwtsiasl
 
 libfwts_la_SOURCES = \