Patchwork [U-Boot,3/5] video: Fix compilation dependency of exynos_dp and exynos_mipi on exynos_fb

login
register
mail settings
Submitter Ajay Kumar
Date Dec. 11, 2012, 11:01 a.m.
Message ID <1355223686-13718-3-git-send-email-ajaykumar.rs@samsung.com>
Download mbox | patch
Permalink /patch/205179/
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Comments

Ajay Kumar - Dec. 11, 2012, 11:01 a.m.
When only DP is used, we need not enable CONFIG_EXYNOS_MIPI_DSIM.
Similarly, when only MIPI is used, we need not enable CONFIG_EXYNOS_DP.
But the current structuring of code forces us to enable both
CONFIG_EXYNOS_MIPI_DSIM and CONFIG_EXYNOS_DP.
This patch adds conditional compilation check to remove the dependency.

Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
---
 drivers/video/exynos_fb.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Simon Glass - Dec. 12, 2012, 2:31 p.m.
On Tue, Dec 11, 2012 at 3:01 AM, Ajay Kumar <ajaykumar.rs@samsung.com> wrote:
> When only DP is used, we need not enable CONFIG_EXYNOS_MIPI_DSIM.
> Similarly, when only MIPI is used, we need not enable CONFIG_EXYNOS_DP.
> But the current structuring of code forces us to enable both
> CONFIG_EXYNOS_MIPI_DSIM and CONFIG_EXYNOS_DP.
> This patch adds conditional compilation check to remove the dependency.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>

Acked-by: Simon Glass <sjg@chromium.org>

> ---
>  drivers/video/exynos_fb.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c
> index d9a3f9a..39d3b74 100644
> --- a/drivers/video/exynos_fb.c
> +++ b/drivers/video/exynos_fb.c
> @@ -103,8 +103,10 @@ static void lcd_panel_on(vidinfo_t *vid)
>
>         udelay(vid->power_on_delay);
>
> +#ifdef CONFIG_EXYNOS_DP
>         if (vid->dp_enabled)
>                 exynos_init_dp();
> +#endif
>
>         if (vid->reset_lcd) {
>                 vid->reset_lcd();
> @@ -120,8 +122,10 @@ static void lcd_panel_on(vidinfo_t *vid)
>         if (vid->enable_ldo)
>                 vid->enable_ldo(1);
>
> +#ifdef CONFIG_EXYNOS_MIPI_DSIM
>         if (vid->mipi_enabled)
>                 exynos_mipi_dsi_init();
> +#endif
>  }
>
>  void lcd_ctrl_init(void *lcdbase)
> --
> 1.7.1
>

Patch

diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c
index d9a3f9a..39d3b74 100644
--- a/drivers/video/exynos_fb.c
+++ b/drivers/video/exynos_fb.c
@@ -103,8 +103,10 @@  static void lcd_panel_on(vidinfo_t *vid)
 
 	udelay(vid->power_on_delay);
 
+#ifdef CONFIG_EXYNOS_DP
 	if (vid->dp_enabled)
 		exynos_init_dp();
+#endif
 
 	if (vid->reset_lcd) {
 		vid->reset_lcd();
@@ -120,8 +122,10 @@  static void lcd_panel_on(vidinfo_t *vid)
 	if (vid->enable_ldo)
 		vid->enable_ldo(1);
 
+#ifdef CONFIG_EXYNOS_MIPI_DSIM
 	if (vid->mipi_enabled)
 		exynos_mipi_dsi_init();
+#endif
 }
 
 void lcd_ctrl_init(void *lcdbase)