From patchwork Tue Dec 11 03:58:55 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Minkyu Kang X-Patchwork-Id: 205124 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id D0D262C00B5 for ; Tue, 11 Dec 2012 14:59:09 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C2F8E4A099; Tue, 11 Dec 2012 04:59:06 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dAMliFAb2ZUf; Tue, 11 Dec 2012 04:59:06 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7C2124A0A2; Tue, 11 Dec 2012 04:59:04 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 98B6E4A0A2 for ; Tue, 11 Dec 2012 04:59:01 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xtgMWaAkoMeR for ; Tue, 11 Dec 2012 04:58:58 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by theia.denx.de (Postfix) with ESMTP id 129434A099 for ; Tue, 11 Dec 2012 04:58:57 +0100 (CET) Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MEU00BCZLQ1B6C0@mailout1.samsung.com> for u-boot@lists.denx.de; Tue, 11 Dec 2012 12:58:51 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.41]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 53.0F.01231.B7FA6C05; Tue, 11 Dec 2012 12:58:51 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-d6-50c6af7b41b7 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 13.0F.01231.B7FA6C05; Tue, 11 Dec 2012 12:58:51 +0900 (KST) Received: from [10.90.45.134] by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MEU003G5LQ3UG00@mmp2.samsung.com> for u-boot@lists.denx.de; Tue, 11 Dec 2012 12:58:51 +0900 (KST) Message-id: <50C6AF7F.40607@samsung.com> Date: Tue, 11 Dec 2012 12:58:55 +0900 From: Minkyu Kang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-version: 1.0 To: "u-boot@lists.denx.de" References: <50C5E8B5.3080805@samsung.com> In-reply-to: <50C5E8B5.3080805@samsung.com> DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsVy+t8zTd3q9ccCDC6dNbR4u7eT3YHR4+yd HYwBjFFcNimpOZllqUX6dglcGddvvWQtWM1ese+PcAPjH9YuRk4OCQETiUMf17NA2GISF+6t Z+ti5OIQEljGKLFr+zsWmKJP2/+zQySmM0q07HzMBpIQEmhmknj2KAHE5hXQkOi6+ABoKgcH i4CqxNx+FZAwG1D46bTtjCC2qICfxNm57xghygUlfky+BzZfRMBQ4u/u3WA2s4CHxIW/i8Fs YQEfiaVvl7NCrNKSWHD5EjuIzSmgLXHszFx2iHodif2t09ggbHmJzWveMoPYLAICEt8mH2IB OUdCQFZi0wFmkPMlBJrZJQ5fXMoO8ZekxMEVN1gmMIrNQnLSLCRjZyEZu4CReRWjaGpBckFx UnquoV5xYm5xaV66XnJ+7iZGSERI7WBc2WBxiFGAg1GJh1dD61iAEGtiWXFl7iFGCQ5mJRHe 0lygEG9KYmVValF+fFFpTmrxIUYfoGsnMkuJJucDozWvJN7Q2MDY0NDS0MzU0tQAh7CSOG+z R0qAkEB6YklqdmpqQWoRzDgmDk6pBkaxRRwCPTx2dr+3JlTGMM8/wuzVFSI9R6nw1ukLL3J0 18lcW/Ttzn++O7rzkutXivot/muyrVn5eV6e+NzGvHqXhSo2TLFn8h9/vP7cv6Z1mh2DngpX eUCAe7vJ438ZP+f9/h2YZ/7nqBPz/6rvaRPmKG/al9yuVDnt0lOhujPrnzSZfDK/IqLEUpyR aKjFXFScCADKHufktQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIIsWRmVeSWpSXmKPExsVy+t9jQd3q9ccCDP5e1rR4u7eT3YHR4+yd HYwBjFENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5 QGOVFMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqGBMH1GBmggYR1jBnXb71kLVjNXrHvj3AD 4x/WLkZODgkBE4lP2/+zQ9hiEhfurWfrYuTiEBKYzijRsvMxG0hCSKCZSeLZowQQm1dAQ6Lr 4gOgZg4OFgFVibn9KiBhNqDw02nbGUFsUQE/ibNz3zFClAtK/Jh8jwXEFhEwlPi7ezeYzSzg IXHh72IwW1jAR2Lp2+WsEKu0JBZcvgR2D6eAtsSxM3PZIep1JPa3TmODsOUlNq95yzyBUWAW khWzkJTNQlK2gJF5FaNoakFyQXFSeq6hXnFibnFpXrpecn7uJkZwvD2T2sG4ssHiEKMAB6MS D6+G1rEAIdbEsuLK3EOMEhzMSiK8pblAId6UxMqq1KL8+KLSnNTiQ4w+wACYyCwlmpwPTAV5 JfGGxiZmRpZGZsYm5sbGOISVxHmbPVIChATSE0tSs1NTC1KLYMYxcXBKNTAy765myrO4qNO4 +Tbbbf//l0q294VKHTj78/vnCymvLkkL/VQObY2xZ7/W0LE8x2jdBQu1A+2z6sPN1Vae/R8r UjklvjfT8yFrmeGsK9PO3H7kxFSTbDvnYde0vZU/l6WcFDm3auGEz8xa132ZUnbsfDb90Rol x+AQ/STvXQ1ezAmfvp5m5vmvxFKckWioxVxUnAgAvNLaG+QCAAA= X-CFilter-Loop: Reflected Subject: [U-Boot] [PATCH v2] universal_c210: check the NULL pointer when get the PMIC X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de PMIC 2.0 require to test return pointer from pmic_get() Signed-off-by: Minkyu Kang Cc: Lukasz Majewski Cc: Wolfgang Denk Acked-by: Lukasz Majewski --- Changes in V2: - Since functions are void type, remove the return value. board/samsung/universal_c210/universal.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/board/samsung/universal_c210/universal.c b/board/samsung/universal_c210/universal.c index 4869798..e742707 100644 --- a/board/samsung/universal_c210/universal.c +++ b/board/samsung/universal_c210/universal.c @@ -343,6 +343,9 @@ static void init_pmic_lcd(void) struct pmic *p = pmic_get("MAX8998_PMIC"); + if (!p) + return; + if (pmic_probe(p)) return; @@ -434,6 +437,9 @@ static void lcd_power_on(void) { struct pmic *p = pmic_get("MAX8998_PMIC"); + if (!p) + return; + if (pmic_probe(p)) return;