Patchwork [PATCH-resent] Fix initialization of ap_table_{max_size, expiration_time}

login
register
mail settings
Submitter Sven Eckelmann
Date Dec. 10, 2012, 1 p.m.
Message ID <1355144416-12017-1-git-send-email-sven@open-mesh.com>
Download mbox | patch
Permalink /patch/204869/
State Accepted
Commit f1b44874c2d91ddfbbc2cf1ede45a742c1e9adbe
Headers show

Comments

Sven Eckelmann - Dec. 10, 2012, 1 p.m.
From: Sven Eckelmann <sven@open-mesh.com>

The config says that the default for ap_table_max_size is 255 and the default
for ap_table_expiration_time is 60. But the code doesn't reflect the default
values mentioned in the sample config file.

These variables completely disable the code for Overlapping Legacy BSS
Condition by default when they are not correctly initialized. WFA certification
requires this feature and therefore an AP would have failed the certification
process unless they were initialized manually using the configuration file.

Signed-hostap: Sven Eckelmann <sven@open-mesh.com>
Signed-hostap: Simon Wunderlich <simon@open-mesh.com>
---
 src/ap/ap_config.c |    3 +++
 1 file changed, 3 insertions(+)
Jouni Malinen - Dec. 17, 2012, 3:46 p.m.
On Mon, Dec 10, 2012 at 02:00:16PM +0100, sven@open-mesh.com wrote:
> The config says that the default for ap_table_max_size is 255 and the default
> for ap_table_expiration_time is 60. But the code doesn't reflect the default
> values mentioned in the sample config file.

Thanks, applied.

Patch

diff --git a/src/ap/ap_config.c b/src/ap/ap_config.c
index 3c699f7..25d26e5 100644
--- a/src/ap/ap_config.c
+++ b/src/ap/ap_config.c
@@ -158,6 +158,9 @@  struct hostapd_config * hostapd_config_defaults(void)
 
 	conf->ht_capab = HT_CAP_INFO_SMPS_DISABLED;
 
+	conf->ap_table_max_size = 255;
+	conf->ap_table_expiration_time = 60;
+
 	return conf;
 }