Patchwork qxl+vnc: register a vm state change handler for dummy spice_server

login
register
mail settings
Submitter Uri Lublin
Date Dec. 10, 2012, 10:36 a.m.
Message ID <d4583279e4bc44c95a0bab5121657602d8e41da9.1355135715.git.uril@redhat.com>
Download mbox | patch
Permalink /patch/204846/
State New
Headers show

Comments

Uri Lublin - Dec. 10, 2012, 10:36 a.m.
When qxl + vnc are used, a dummy spice_server is initialized.
The spice_server has to be told when the VM runstate changes,
which is what this patch does.

Without it, from qxl_send_events(), the following error message is shown:
  qxl_send_events: spice-server bug: guest stopped, ignoring
---
 ui/spice-core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Uri Lublin - Dec. 12, 2012, 2:45 p.m.
On 12/10/2012 12:36 PM, Uri Lublin wrote:
> When qxl + vnc are used, a dummy spice_server is initialized.
> The spice_server has to be told when the VM runstate changes,
> which is what this patch does.
>
> Without it, from qxl_send_events(), the following error message is shown:
>    qxl_send_events: spice-server bug: guest stopped, ignoring

Signed-off-by: Uri Lublin <uril@redhat.com>

> ---
>   ui/spice-core.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 261c6f2..6a6ab12 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -732,6 +732,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
>            */
>           spice_server = spice_server_new();
>           spice_server_init(spice_server,&core_interface);
> +        qemu_add_vm_change_state_handler(vm_change_state_handler,&spice_server);
>       }
>
>       return spice_server_add_interface(spice_server, sin);
Gerd Hoffmann - Dec. 12, 2012, 3:31 p.m.
On 12/12/12 15:45, Uri Lublin wrote:
> On 12/10/2012 12:36 PM, Uri Lublin wrote:
>> When qxl + vnc are used, a dummy spice_server is initialized.
>> The spice_server has to be told when the VM runstate changes,
>> which is what this patch does.
>>
>> Without it, from qxl_send_events(), the following error message is shown:
>>    qxl_send_events: spice-server bug: guest stopped, ignoring
> 
> Signed-off-by: Uri Lublin <uril@redhat.com>

=== checkpatch complains ===
WARNING: line over 80 characters
#10: FILE: ui/spice-core.c:739:
+        qemu_add_vm_change_state_handler(vm_change_state_handler,
&spice_server);

please fix & resend.

thanks,
  Gerd

Patch

diff --git a/ui/spice-core.c b/ui/spice-core.c
index 261c6f2..6a6ab12 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -732,6 +732,7 @@  int qemu_spice_add_interface(SpiceBaseInstance *sin)
          */
         spice_server = spice_server_new();
         spice_server_init(spice_server, &core_interface);
+        qemu_add_vm_change_state_handler(vm_change_state_handler, &spice_server);
     }
 
     return spice_server_add_interface(spice_server, sin);