Patchwork [3/4] fix implicit declaration of syscall() in linux-user/syscall.c

login
register
mail settings
Submitter John Spencer
Date Dec. 10, 2012, 6:59 a.m.
Message ID <1355122786-29243-3-git-send-email-maillist-qemu@barfooze.de>
Download mbox | patch
Permalink /patch/204826/
State New
Headers show

Comments

John Spencer - Dec. 10, 2012, 6:59 a.m.
Signed-off-by: John Spencer <maillist-qemu@barfooze.de>

---
 linux-user/syscall.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Stefan Weil - Dec. 10, 2012, 5:49 p.m.
Am 10.12.2012 07:59, schrieb John Spencer:
> Signed-off-by: John Spencer<maillist-qemu@barfooze.de>
>
> ---
>   linux-user/syscall.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 31d5276..fabbcd7 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -39,6 +39,7 @@
>   #include<sys/resource.h>
>   #include<sys/mman.h>
>   #include<sys/swap.h>
> +#include<sys/syscall.h>
>   #include<signal.h>
>   #include<sched.h>
>   #ifdef __ia64__


This is a workaround for a missing declaration of function syscall
in musl's unistd.h. See my comment to patch 1 for more information.
John Spencer - Dec. 11, 2012, 1:23 a.m.
On 12/10/2012 06:49 PM, Stefan Weil wrote:
> Am 10.12.2012 07:59, schrieb John Spencer:
>> +#include<sys/syscall.h>

>
> This is a workaround for a missing declaration of function syscall
> in musl's unistd.h. See my comment to patch 1 for more information.
>

thanks for noticing! fixed in musl:

http://git.musl-libc.org/cgit/musl/commit/?id=baf246e559e915a78a9703e10d15020c7edee423

how do we proceed with the 2 good patches ? is there anything i have to 
do to get them merged, now that you put the "Reviewed-by" stamp on them ?

Thanks,
John Spencer
Stefan Weil - Dec. 11, 2012, 6:07 a.m.
Am 11.12.2012 02:23, schrieb John Spencer:
> On 12/10/2012 06:49 PM, Stefan Weil wrote:
>> Am 10.12.2012 07:59, schrieb John Spencer:
>>> +#include<sys/syscall.h>
>
>>
>> This is a workaround for a missing declaration of function syscall
>> in musl's unistd.h. See my comment to patch 1 for more information.
>>
>
> thanks for noticing! fixed in musl:
>
> http://git.musl-libc.org/cgit/musl/commit/?id=baf246e559e915a78a9703e10d15020c7edee423 
>
>
> how do we proceed with the 2 good patches ? is there anything i have 
> to do to get them merged, now that you put the "Reviewed-by" stamp on 
> them ?
>
> Thanks,
> John Spencer


I assume that Stefan Hajnoczi will add them to the qemu-trivial queue.
Just wait and resend those patches if nothing happens the next two weeks.

Regards,
Stefan Weil

Patch

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 31d5276..fabbcd7 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -39,6 +39,7 @@ 
 #include <sys/resource.h>
 #include <sys/mman.h>
 #include <sys/swap.h>
+#include <sys/syscall.h>
 #include <signal.h>
 #include <sched.h>
 #ifdef __ia64__