Patchwork [v4,1/3] target-i386:define name of breakpoint bit in dr7

login
register
mail settings
Submitter liguang
Date Dec. 10, 2012, 2:22 a.m.
Message ID <1355106144-30846-1-git-send-email-lig.fnst@cn.fujitsu.com>
Download mbox | patch
Permalink /patch/204809/
State New
Headers show

Comments

liguang - Dec. 10, 2012, 2:22 a.m.
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
 target-i386/cpu.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
liguang - Dec. 14, 2012, 1:32 a.m.
Hi, 

any comment on this version?

在 2012-12-10一的 10:22 +0800,liguang写道:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
>  target-i386/cpu.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 90ef1ff..29245d1 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -231,6 +231,13 @@
>  #define DR7_TYPE_SHIFT  16
>  #define DR7_LEN_SHIFT   18
>  #define DR7_FIXED_1     0x00000400
> +#define DR7_LOCAL_BP_MASK   0x55
> +#define DR7_MAX_BP      4
> +#define DR7_TYPE_BP_INST     0x0
> +#define DR7_TYPE_DATA_WR     0x1
> +#define DR7_TYPE_IO_RW       0x2
> +#define DR7_TYPE_DATA_RW     0x3
> +
>  
>  #define PG_PRESENT_BIT	0
>  #define PG_RW_BIT	1
liguang - Jan. 11, 2013, 1:47 a.m.
Hi, Andreas

can these patches get an ack from you?
or they were obsoleted?


在 2012-12-10一的 10:22 +0800,liguang写道:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
>  target-i386/cpu.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 90ef1ff..29245d1 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -231,6 +231,13 @@
>  #define DR7_TYPE_SHIFT  16
>  #define DR7_LEN_SHIFT   18
>  #define DR7_FIXED_1     0x00000400
> +#define DR7_LOCAL_BP_MASK   0x55
> +#define DR7_MAX_BP      4
> +#define DR7_TYPE_BP_INST     0x0
> +#define DR7_TYPE_DATA_WR     0x1
> +#define DR7_TYPE_IO_RW       0x2
> +#define DR7_TYPE_DATA_RW     0x3
> +
>  
>  #define PG_PRESENT_BIT	0
>  #define PG_RW_BIT	1
Andreas Färber - Jan. 11, 2013, 4 p.m.
Hi Guang,

Am 11.01.2013 02:47, schrieb li guang:
> can these patches get an ack from you?

I'm waiting on feedback from the previous reviewers... CC'ing.

> or they were obsoleted?

No, I don't spot any need to rebase. However, patch 3/3 is tab-damaged,
please run scripts/checkpatch.pl. That can be automated as a git hook.

Regards,
Andreas

> 在 2012-12-10一的 10:22 +0800,liguang写道:
>> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
>> ---
>>  target-i386/cpu.h |    7 +++++++
>>  1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
>> index 90ef1ff..29245d1 100644
>> --- a/target-i386/cpu.h
>> +++ b/target-i386/cpu.h
>> @@ -231,6 +231,13 @@
>>  #define DR7_TYPE_SHIFT  16
>>  #define DR7_LEN_SHIFT   18
>>  #define DR7_FIXED_1     0x00000400
>> +#define DR7_LOCAL_BP_MASK   0x55
>> +#define DR7_MAX_BP      4
>> +#define DR7_TYPE_BP_INST     0x0
>> +#define DR7_TYPE_DATA_WR     0x1
>> +#define DR7_TYPE_IO_RW       0x2
>> +#define DR7_TYPE_DATA_RW     0x3
>> +
>>  
>>  #define PG_PRESENT_BIT	0
>>  #define PG_RW_BIT	1
Andreas Färber - Jan. 11, 2013, 4:10 p.m.
Am 10.12.2012 03:22, schrieb liguang:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>

For a patch series consisting of more than 1 patch, please use a cover
letter (e.g., --cover-letter) that details the change history of the
versions. That also facilitates commenting on the series vs. a single patch.

> ---
>  target-i386/cpu.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 90ef1ff..29245d1 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -231,6 +231,13 @@
>  #define DR7_TYPE_SHIFT  16
>  #define DR7_LEN_SHIFT   18
>  #define DR7_FIXED_1     0x00000400
> +#define DR7_LOCAL_BP_MASK   0x55
> +#define DR7_MAX_BP      4
> +#define DR7_TYPE_BP_INST     0x0
> +#define DR7_TYPE_DATA_WR     0x1
> +#define DR7_TYPE_IO_RW       0x2
> +#define DR7_TYPE_DATA_RW     0x3
> +
>  
>  #define PG_PRESENT_BIT	0
>  #define PG_RW_BIT	1

These defines are being introduced but not used in this patch yet. If
you were to replace, e.g., 4 -> DR7_MAX_BP in this patch instead of
patch 3/3, I would see a value in cherry-picking it. Assuming there is
agreement on that name, of course.

Andreas
liguang - Jan. 14, 2013, 2:39 a.m.
在 2013-01-11五的 17:10 +0100,Andreas Färber写道:
> Am 10.12.2012 03:22, schrieb liguang:
> > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> 
> For a patch series consisting of more than 1 patch, please use a cover
> letter (e.g., --cover-letter) that details the change history of the
> versions. That also facilitates commenting on the series vs. a single patch.
> 
> > ---
> >  target-i386/cpu.h |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> > index 90ef1ff..29245d1 100644
> > --- a/target-i386/cpu.h
> > +++ b/target-i386/cpu.h
> > @@ -231,6 +231,13 @@
> >  #define DR7_TYPE_SHIFT  16
> >  #define DR7_LEN_SHIFT   18
> >  #define DR7_FIXED_1     0x00000400
> > +#define DR7_LOCAL_BP_MASK   0x55
> > +#define DR7_MAX_BP      4
> > +#define DR7_TYPE_BP_INST     0x0
> > +#define DR7_TYPE_DATA_WR     0x1
> > +#define DR7_TYPE_IO_RW       0x2
> > +#define DR7_TYPE_DATA_RW     0x3
> > +
> >  
> >  #define PG_PRESENT_BIT	0
> >  #define PG_RW_BIT	1
> 
> These defines are being introduced but not used in this patch yet. If
> you were to replace, e.g., 4 -> DR7_MAX_BP in this patch instead of
> patch 3/3, I would see a value in cherry-picking it. Assuming there is
> agreement on that name, of course.
> 
> Andreas
> 


OK, I will squash them into one patch.

Patch

diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index 90ef1ff..29245d1 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -231,6 +231,13 @@ 
 #define DR7_TYPE_SHIFT  16
 #define DR7_LEN_SHIFT   18
 #define DR7_FIXED_1     0x00000400
+#define DR7_LOCAL_BP_MASK   0x55
+#define DR7_MAX_BP      4
+#define DR7_TYPE_BP_INST     0x0
+#define DR7_TYPE_DATA_WR     0x1
+#define DR7_TYPE_IO_RW       0x2
+#define DR7_TYPE_DATA_RW     0x3
+
 
 #define PG_PRESENT_BIT	0
 #define PG_RW_BIT	1