Patchwork libglib2: don't try to use DTrace/GCov/SystemTap for host build

login
register
mail settings
Submitter Thomas Petazzoni
Date Dec. 9, 2012, 7:16 p.m.
Message ID <1355080604-27155-1-git-send-email-thomas.petazzoni@free-electrons.com>
Download mbox | patch
Permalink /patch/204774/
State Accepted
Commit 695f52c17488e90cac1d4dc5a2a48ae94f2c5bb9
Headers show

Comments

Thomas Petazzoni - Dec. 9, 2012, 7:16 p.m.
We really only need the host build of libglib2 for a few helper
programs that are used for the target build of libglib2. Therefore,
trying to use bells and whistles like DTrace, GCov and SystemTap is
useful.

And it is actually harmful, since it is causing build failures on the
gcc110 PowerPC-based autobuilder that apparently has some
DTrace-feature installed. This commit therefore fixes:

  http://autobuild.buildroot.org/results/1c62d1ce10937bd21f5afcb73782b939d10c2038/build-end.log

Which has been polluting our autobuilder logs since several weeks now.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/libglib2/libglib2.mk |    3 +++
 1 file changed, 3 insertions(+)
Baruch Siach - Dec. 9, 2012, 7:26 p.m.
Hi Thomas,

On Sun, Dec 09, 2012 at 08:16:44PM +0100, Thomas Petazzoni wrote:
> We really only need the host build of libglib2 for a few helper
> programs that are used for the target build of libglib2. Therefore,
> trying to use bells and whistles like DTrace, GCov and SystemTap is
> useful.

Not?

> And it is actually harmful, since it is causing build failures on the
> gcc110 PowerPC-based autobuilder that apparently has some
> DTrace-feature installed. This commit therefore fixes:
> 
>   http://autobuild.buildroot.org/results/1c62d1ce10937bd21f5afcb73782b939d10c2038/build-end.log
> 
> Which has been polluting our autobuilder logs since several weeks now.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/libglib2/libglib2.mk |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/libglib2/libglib2.mk b/package/libglib2/libglib2.mk
> index a32cab2..4427431 100644
> --- a/package/libglib2/libglib2.mk
> +++ b/package/libglib2/libglib2.mk
> @@ -53,6 +53,9 @@ endif
>  HOST_LIBGLIB2_CONF_OPT = \
>  		--disable-gtk-doc \
>  		--enable-debug=no \
> +		--disable-dtrace \
> +		--disable-systemtap \
> +		--disable-gcov
>  
>  LIBGLIB2_DEPENDENCIES = host-pkgconf host-libglib2 libffi zlib $(if $(BR2_NEEDS_GETTEXT),gettext)

baruch
Thomas Petazzoni - Dec. 10, 2012, 8:16 a.m.
Dear Baruch Siach,

On Sun, 9 Dec 2012 21:26:20 +0200, Baruch Siach wrote:

> On Sun, Dec 09, 2012 at 08:16:44PM +0100, Thomas Petazzoni wrote:
> > We really only need the host build of libglib2 for a few helper
> > programs that are used for the target build of libglib2. Therefore,
> > trying to use bells and whistles like DTrace, GCov and SystemTap is
> > useful.
> 
> Not?

Yes, thanks, I've sent a v2 that fixes that.

Thomas

Patch

diff --git a/package/libglib2/libglib2.mk b/package/libglib2/libglib2.mk
index a32cab2..4427431 100644
--- a/package/libglib2/libglib2.mk
+++ b/package/libglib2/libglib2.mk
@@ -53,6 +53,9 @@  endif
 HOST_LIBGLIB2_CONF_OPT = \
 		--disable-gtk-doc \
 		--enable-debug=no \
+		--disable-dtrace \
+		--disable-systemtap \
+		--disable-gcov
 
 LIBGLIB2_DEPENDENCIES = host-pkgconf host-libglib2 libffi zlib $(if $(BR2_NEEDS_GETTEXT),gettext)