Patchwork [20/51] package/libbsd: new package

login
register
mail settings
Submitter Yann E. MORIN
Date Dec. 9, 2012, 4:34 p.m.
Message ID <1355070924-8009-21-git-send-email-yann.morin.1998@free.fr>
Download mbox | patch
Permalink /patch/204722/
State Superseded
Headers show

Comments

Yann E. MORIN - Dec. 9, 2012, 4:34 p.m.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/Config.in        |    1 +
 package/libbsd/Config.in |   17 +++++++++++++++++
 package/libbsd/libbsd.mk |   25 +++++++++++++++++++++++++
 3 files changed, 43 insertions(+), 0 deletions(-)
 create mode 100644 package/libbsd/Config.in
 create mode 100644 package/libbsd/libbsd.mk
Yann E. MORIN - Dec. 9, 2012, 6:05 p.m.
Hello All,

On Sunday 09 December 2012 Yann E. MORIN wrote:
> diff --git a/package/libbsd/Config.in b/package/libbsd/Config.in
> new file mode 100644
> index 0000000..d1f9e46
> --- /dev/null
> +++ b/package/libbsd/Config.in
> @@ -0,0 +1,17 @@
> +config BR2_PACKAGE_LIBBSD_AVAILABLE
> +	def_bool y

As has already been pointed out on IRC, these _AVAILABLE symbols should
not exist. Affected packages: libbsd, libedit2, qemu.

I've already removed them locally, but will wait a bit for more review
before I post a new version of this series.

Regards,
Yann E. MORIN.
Thomas Petazzoni - Dec. 9, 2012, 6:46 p.m.
Dear Yann E. MORIN,

On Sun,  9 Dec 2012 17:34:53 +0100, Yann E. MORIN wrote:

> +LIBBSD_AUTORECONF      = YES
> +LIBBSD_AUTORECONF_OPT  = -f -i

Justification for AUTORECONF?

Thanks!

Thomas
Yann E. MORIN - Dec. 9, 2012, 10:06 p.m.
Thomas, All,

On Sunday 09 December 2012 Thomas Petazzoni wrote:
> On Sun,  9 Dec 2012 17:34:53 +0100, Yann E. MORIN wrote:
> 
> > +LIBBSD_AUTORECONF      = YES
> > +LIBBSD_AUTORECONF_OPT  = -f -i
> 
> Justification for AUTORECONF?

Hmmm... I remember that I needed to explicitly specify the autoreconf
flags, or the standard autoreconf would not work. However, I don't
remember why autoreconf was needed in the first place...

I removed it, and it still builds OK.

I'll redo a complete build of the stack with this change, to see if it
has impacts further down along the line...

Regards,
Yann E. MORIN.

Patch

diff --git a/package/Config.in b/package/Config.in
index 559a093..37910c3 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -503,6 +503,7 @@  source "package/libargtable2/Config.in"
 source "package/argp-standalone/Config.in"
 source "package/boost/Config.in"
 source "package/libatomic_ops/Config.in"
+source "package/libbsd/Config.in"
 source "package/libcap/Config.in"
 source "package/libcap-ng/Config.in"
 source "package/libdaemon/Config.in"
diff --git a/package/libbsd/Config.in b/package/libbsd/Config.in
new file mode 100644
index 0000000..d1f9e46
--- /dev/null
+++ b/package/libbsd/Config.in
@@ -0,0 +1,17 @@ 
+config BR2_PACKAGE_LIBBSD_AVAILABLE
+	def_bool y
+
+comment "libbsd requires (other packages)"
+	depends on !BR2_PACKAGE_LIBBSD_AVAILABLE
+
+config BR2_PACKAGE_LIBBSD
+	bool "libbsd"
+	depends on BR2_PACKAGE_LIBBSD_AVAILABLE
+	help
+	  This library provides useful functions commonly found on BSD
+	  systems, and lacking on others like GNU systems, thus making
+	  it easier to port projects with strong BSD origins, without
+	  needing to embed the same code over and over again on each
+	  project.
+	  
+	  http://libbsd.freedesktop.org/
diff --git a/package/libbsd/libbsd.mk b/package/libbsd/libbsd.mk
new file mode 100644
index 0000000..d7438e8
--- /dev/null
+++ b/package/libbsd/libbsd.mk
@@ -0,0 +1,25 @@ 
+#############################################################
+#
+# libbsd
+#
+#############################################################
+
+LIBBSD_VERSION         = 0.4.2
+LIBBSD_SOURCE          = libbsd-$(LIBBSD_VERSION).tar.gz
+LIBBSD_SITE            = http://libbsd.freedesktop.org/releases
+LIBBSD_LICENSE         = BSD-3c MIT
+LIBBSD_LICENSE_FILES   = LICENSE
+
+# man-pages are BSD-4c, so that license only matters
+# if doc is kept in the target rootfs
+ifeq ($(BR2_HAVE_DOCUMENTATION),y)
+LIBBSD_LICENSE        += BSD-4c
+endif
+
+LIBBSD_AUTORECONF      = YES
+LIBBSD_AUTORECONF_OPT  = -f -i
+LIBBSD_DEPENDENCIES    = host-automake
+
+LIBBSD_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))