Patchwork driver_nl80211: disable 11b rates on interface change

login
register
mail settings
Submitter Arik Nemtsov
Date Dec. 9, 2012, 8:30 a.m.
Message ID <1355041826-18704-1-git-send-email-arik@wizery.com>
Download mbox | patch
Permalink /patch/204691/
State Rejected
Headers show

Comments

Arik Nemtsov - Dec. 9, 2012, 8:30 a.m.
From: Eliad Peller <eliad@wizery.com>

11b rates were disabled during interface addition, but
not on interface mode change.

Disable/Enable 11b rates in wpa_driver_nl80211_set_mode(),
according to the interface type (p2p or not).

Signed-hostap: Eliad Peller <eliad@wizery.com>
---
 src/drivers/driver_nl80211.c |    2 ++
 1 file changed, 2 insertions(+)
Jouni Malinen - Dec. 23, 2012, 10:59 a.m.
On Sun, Dec 09, 2012 at 10:30:26AM +0200, Arik Nemtsov wrote:
> 11b rates were disabled during interface addition, but
> not on interface mode change.
> 
> Disable/Enable 11b rates in wpa_driver_nl80211_set_mode(),
> according to the interface type (p2p or not).

> +	nl80211_disable_11b_rates(drv, drv->ifindex, is_p2p_interface(nlmode));

Is this really needed? There is a call to nl80211_disable_11b_rates()
just above this in the same wpa_driver_nl80211_set_mode() function (from
commits edb9bfba8914932aa44657c41fb99dc984e1f8d2 and
1d0c6fb1ebe1feaec76bfb7f00c05349e18973aa).
Arik Nemtsov - Dec. 23, 2012, 9:59 p.m.
On Sun, Dec 23, 2012 at 12:59 PM, Jouni Malinen <j@w1.fi> wrote:
> On Sun, Dec 09, 2012 at 10:30:26AM +0200, Arik Nemtsov wrote:
>> 11b rates were disabled during interface addition, but
>> not on interface mode change.
>>
>> Disable/Enable 11b rates in wpa_driver_nl80211_set_mode(),
>> according to the interface type (p2p or not).
>
>> +     nl80211_disable_11b_rates(drv, drv->ifindex, is_p2p_interface(nlmode));
>
> Is this really needed? There is a call to nl80211_disable_11b_rates()
> just above this in the same wpa_driver_nl80211_set_mode() function (from
> commits edb9bfba8914932aa44657c41fb99dc984e1f8d2 and
> 1d0c6fb1ebe1feaec76bfb7f00c05349e18973aa).

You're right of course. This was ported from an old version and we
didn't notice the change.

Arik

Patch

diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
index 297f677..a1255f3 100644
--- a/src/drivers/driver_nl80211.c
+++ b/src/drivers/driver_nl80211.c
@@ -7206,6 +7206,8 @@  done:
 		wpa_printf(MSG_DEBUG, "nl80211: Failed to register Action "
 			   "frame processing - ignore for now");
 
+	nl80211_disable_11b_rates(drv, drv->ifindex, is_p2p_interface(nlmode));
+
 	return 0;
 }