From patchwork Sat Dec 8 23:11:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Ding X-Patchwork-Id: 204680 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 62D242C0131 for ; Sun, 9 Dec 2012 10:12:13 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752128Ab2LHXLo (ORCPT ); Sat, 8 Dec 2012 18:11:44 -0500 Received: from mail-qc0-f174.google.com ([209.85.216.174]:38913 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469Ab2LHXLn (ORCPT ); Sat, 8 Dec 2012 18:11:43 -0500 Received: by mail-qc0-f174.google.com with SMTP id o22so887721qcr.19 for ; Sat, 08 Dec 2012 15:11:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=OMdGnEwY73x2kDd1D8l8aYS4fDE9jKcvhP9xzM4IhD4=; b=s2hxL7814F1MsU4Pj20LY+EB66dN8SSdumdMpUZULPemhkEXrrcIKqGZEgmwju765I CltZFzetNkxzfe8pw1hry8BOIYQiIlLxrUKFZQ9uzt/AfF9C+gsKxTxm87RcbrEAMRNW txqCXiHPla5/vR1WlrWLSsdQOKM38mmEVbjVYLy5pFxiYQjVKUqtPI2hrjFSo1DpySe7 4d9Wb6SiOdf3WVTRhPdstY9x+mti/tME/SVQbrcDwt6rsG4Ket9agDbrtfsWEmv698pP FXAOpDf8jFJznRe4SxuObc4CuFdKxFRal6zAHixtYAwi6jOxF6NkwMtTOP9OnqSAGgnL +QfA== Received: by 10.49.25.102 with SMTP id b6mr20178444qeg.27.1355008302072; Sat, 08 Dec 2012 15:11:42 -0800 (PST) Received: from localhost.localdomain (ec2-54-243-39-165.compute-1.amazonaws.com. [54.243.39.165]) by mx.google.com with ESMTPS id cd7sm1281531qab.9.2012.12.08.15.11.40 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 08 Dec 2012 15:11:41 -0800 (PST) From: Cong Ding To: Michael Buesch , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Cong Ding Subject: [PATCH] ssb: use WARN in main.c Date: Sat, 8 Dec 2012 23:11:06 +0000 Message-Id: <1355008266-5419-1-git-send-email-dinggnu@gmail.com> X-Mailer: git-send-email 1.7.4.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use WARN rather than printk followed by WARN_ON(1), for conciseness. Signed-off-by: Cong Ding --- drivers/ssb/main.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c index bd7115c..c82c5c9 100644 --- a/drivers/ssb/main.c +++ b/drivers/ssb/main.c @@ -1133,8 +1133,7 @@ static u32 ssb_tmslow_reject_bitmask(struct ssb_device *dev) case SSB_IDLOW_SSBREV_27: /* same here */ return SSB_TMSLOW_REJECT; /* this is a guess */ default: - printk(KERN_INFO "ssb: Backplane Revision 0x%.8X\n", rev); - WARN_ON(1); + WARN(1, KERN_INFO "ssb: Backplane Revision 0x%.8X\n", rev); } return (SSB_TMSLOW_REJECT | SSB_TMSLOW_REJECT_23); }