Patchwork ssb: use WARN in main.c

login
register
mail settings
Submitter Cong Ding
Date Dec. 8, 2012, 11:11 p.m.
Message ID <1355008266-5419-1-git-send-email-dinggnu@gmail.com>
Download mbox | patch
Permalink /patch/204680/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Cong Ding - Dec. 8, 2012, 11:11 p.m.
Use WARN rather than printk followed by WARN_ON(1), for conciseness.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
 drivers/ssb/main.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

Patch

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index bd7115c..c82c5c9 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -1133,8 +1133,7 @@  static u32 ssb_tmslow_reject_bitmask(struct ssb_device *dev)
 	case SSB_IDLOW_SSBREV_27:     /* same here */
 		return SSB_TMSLOW_REJECT;	/* this is a guess */
 	default:
-		printk(KERN_INFO "ssb: Backplane Revision 0x%.8X\n", rev);
-		WARN_ON(1);
+		WARN(1, KERN_INFO "ssb: Backplane Revision 0x%.8X\n", rev);
 	}
 	return (SSB_TMSLOW_REJECT | SSB_TMSLOW_REJECT_23);
 }