Patchwork acpi: acpidump: print a message if no ACPI tables could be found.

login
register
mail settings
Submitter Colin King
Date Dec. 7, 2012, 6:33 p.m.
Message ID <1354905216-29813-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/204595/
State Accepted
Headers show

Comments

Colin King - Dec. 7, 2012, 6:33 p.m.
From: Colin Ian King <colin.king@canonical.com>

Some systems don't have ACPI tables, so emit a message if non can
be found.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/acpidump/acpidump.c | 4 ++++
 1 file changed, 4 insertions(+)
Keng-Yu Lin - Dec. 12, 2012, 3:19 a.m.
On Sat, Dec 8, 2012 at 2:33 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Some systems don't have ACPI tables, so emit a message if non can
> be found.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/acpidump/acpidump.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c
> index 435608c..6cbbf85 100644
> --- a/src/acpi/acpidump/acpidump.c
> +++ b/src/acpi/acpidump/acpidump.c
> @@ -1767,6 +1767,10 @@ static int acpidump_test1(fwts_framework *fw)
>                 fwts_log_nl(fw);
>         }
>
> +       /* Some systems don't have any ACPI tables */
> +       if (!i)
> +               fwts_log_info(fw, "Cannot find any ACPI tables.");
> +
>         return FWTS_OK;
>  }
>
> --
> 1.8.0
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Dec. 12, 2012, 6:21 a.m.
On 12/08/2012 02:33 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Some systems don't have ACPI tables, so emit a message if non can
> be found.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/acpidump/acpidump.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c
> index 435608c..6cbbf85 100644
> --- a/src/acpi/acpidump/acpidump.c
> +++ b/src/acpi/acpidump/acpidump.c
> @@ -1767,6 +1767,10 @@ static int acpidump_test1(fwts_framework *fw)
>   		fwts_log_nl(fw);
>   	}
>
> +	/* Some systems don't have any ACPI tables */
> +	if (!i)
> +		fwts_log_info(fw, "Cannot find any ACPI tables.");
> +
>   	return FWTS_OK;
>   }
>
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c
index 435608c..6cbbf85 100644
--- a/src/acpi/acpidump/acpidump.c
+++ b/src/acpi/acpidump/acpidump.c
@@ -1767,6 +1767,10 @@  static int acpidump_test1(fwts_framework *fw)
 		fwts_log_nl(fw);
 	}
 
+	/* Some systems don't have any ACPI tables */
+	if (!i)
+		fwts_log_info(fw, "Cannot find any ACPI tables.");
+
 	return FWTS_OK;
 }