Patchwork [1/4] multiboot: use FWCfgState* as argument instead of void*

login
register
mail settings
Submitter Eduardo Habkost
Date Dec. 7, 2012, 4:07 p.m.
Message ID <1354896456-21120-2-git-send-email-ehabkost@redhat.com>
Download mbox | patch
Permalink /patch/204575/
State New
Headers show

Comments

Eduardo Habkost - Dec. 7, 2012, 4:07 p.m.
There's no point in using void* if we can simply use the right type for
the argument (FWCfgState*).

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Anthony Liguori <aliguori@us.ibm.com>
---
 hw/multiboot.c | 2 +-
 hw/multiboot.h | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

Patch

diff --git a/hw/multiboot.c b/hw/multiboot.c
index 09ec5b2..06bbf4c 100644
--- a/hw/multiboot.c
+++ b/hw/multiboot.c
@@ -124,7 +124,7 @@  static void mb_add_mod(MultibootState *s,
     s->mb_mods_count++;
 }
 
-int load_multiboot(void *fw_cfg,
+int load_multiboot(FWCfgState *fw_cfg,
                    FILE *f,
                    const char *kernel_filename,
                    const char *initrd_filename,
diff --git a/hw/multiboot.h b/hw/multiboot.h
index 98fb1b7..33c82b1 100644
--- a/hw/multiboot.h
+++ b/hw/multiboot.h
@@ -1,7 +1,9 @@ 
 #ifndef QEMU_MULTIBOOT_H
 #define QEMU_MULTIBOOT_H
 
-int load_multiboot(void *fw_cfg,
+#include "fw_cfg.h"
+
+int load_multiboot(FWCfgState *fw_cfg,
                    FILE *f,
                    const char *kernel_filename,
                    const char *initrd_filename,