Patchwork acpi: apicinstance: make this an Intel x86 only test

login
register
mail settings
Submitter Colin King
Date Dec. 7, 2012, 4:16 p.m.
Message ID <1354897002-16155-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/204570/
State Accepted
Headers show

Comments

Colin King - Dec. 7, 2012, 4:16 p.m.
From: Colin Ian King <colin.king@canonical.com>

This test does not make much sense on non-x86 machines, so make it
an Intel x86 only test.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/apicinstance/apicinstance.c | 4 ++++
 1 file changed, 4 insertions(+)
Keng-Yu Lin - Dec. 12, 2012, 3:15 a.m.
On Sat, Dec 8, 2012 at 12:16 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> This test does not make much sense on non-x86 machines, so make it
> an Intel x86 only test.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/apicinstance/apicinstance.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/acpi/apicinstance/apicinstance.c b/src/acpi/apicinstance/apicinstance.c
> index 60416a2..a18b6dc 100644
> --- a/src/acpi/apicinstance/apicinstance.c
> +++ b/src/acpi/apicinstance/apicinstance.c
> @@ -19,6 +19,8 @@
>
>  #include "fwts.h"
>
> +#ifdef FWTS_ARCH_INTEL
> +
>  static int apicinstance_test1(fwts_framework *fw)
>  {
>         fwts_acpi_table_info *first_madt_table = NULL;
> @@ -82,3 +84,5 @@ static fwts_framework_ops apicinstance_ops = {
>  };
>
>  FWTS_REGISTER(apicinstance, &apicinstance_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH);
> +
> +#endif
> --
> 1.8.0
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Dec. 12, 2012, 6:48 a.m.
On 12/08/2012 12:16 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> This test does not make much sense on non-x86 machines, so make it
> an Intel x86 only test.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/apicinstance/apicinstance.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/src/acpi/apicinstance/apicinstance.c b/src/acpi/apicinstance/apicinstance.c
> index 60416a2..a18b6dc 100644
> --- a/src/acpi/apicinstance/apicinstance.c
> +++ b/src/acpi/apicinstance/apicinstance.c
> @@ -19,6 +19,8 @@
>
>   #include "fwts.h"
>
> +#ifdef FWTS_ARCH_INTEL
> +
>   static int apicinstance_test1(fwts_framework *fw)
>   {
>   	fwts_acpi_table_info *first_madt_table = NULL;
> @@ -82,3 +84,5 @@ static fwts_framework_ops apicinstance_ops = {
>   };
>
>   FWTS_REGISTER(apicinstance, &apicinstance_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH);
> +
> +#endif
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/src/acpi/apicinstance/apicinstance.c b/src/acpi/apicinstance/apicinstance.c
index 60416a2..a18b6dc 100644
--- a/src/acpi/apicinstance/apicinstance.c
+++ b/src/acpi/apicinstance/apicinstance.c
@@ -19,6 +19,8 @@ 
 
 #include "fwts.h"
 
+#ifdef FWTS_ARCH_INTEL
+
 static int apicinstance_test1(fwts_framework *fw)
 {
 	fwts_acpi_table_info *first_madt_table = NULL;
@@ -82,3 +84,5 @@  static fwts_framework_ops apicinstance_ops = {
 };
 
 FWTS_REGISTER(apicinstance, &apicinstance_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH);
+
+#endif