From patchwork Fri Dec 7 16:06:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 204567 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 2D28C2C00C1 for ; Sat, 8 Dec 2012 03:06:59 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1355501220; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Date:From:To:Cc:Subject:Message-ID:Reply-To: References:MIME-Version:Content-Type:Content-Disposition: In-Reply-To:User-Agent:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=HU1n6AxagjF6kP6IHg54hOd90fI=; b=Ih/ix8AHHf7O5Hx T2g+OOZ2QOGy2ojVoih5GCmAWlkQW9VuMeKVz+uVL8iedF6yHtK3YrHYh2RPT2SS Wp+qCL5Fgdidvs/Lmf9b8EhyDPbzzcyyig49oB5ohMf0m+hgLT0RP1vVamhlx0Pc x6aNAeMFgpoUKLGZ8YrFntcMvuuk= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Date:From:To:Cc:Subject:Message-ID:Reply-To:References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To:User-Agent:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=d//92SbtVdGx5YICShIRAywXb3TJ7RRJ64H3ZNhKRKpD4U/5ZLpafABj5Ny6tE bV7U9b9l0t/CELPnxeCdjCbyNJAaKy0R1971toFxxSTpEQQj/UEylGkBqFZQqoHq 8A3/KI9wdVOSI+iHvf1N+40CzRbp0GgEbTlFDWLBLdYRk=; Received: (qmail 26864 invoked by alias); 7 Dec 2012 16:06:55 -0000 Received: (qmail 26850 invoked by uid 22791); 7 Dec 2012 16:06:54 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, SPF_HELO_PASS, TW_BX, TW_DB X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Dec 2012 16:06:49 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB7G6nTZ011789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 Dec 2012 11:06:49 -0500 Received: from zalov.redhat.com (vpn1-4-240.ams2.redhat.com [10.36.4.240]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB7G6lhB009140 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 7 Dec 2012 11:06:48 -0500 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.redhat.com (8.14.5/8.14.5) with ESMTP id qB7G6kur021044; Fri, 7 Dec 2012 17:06:46 +0100 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id qB7G6jvP021043; Fri, 7 Dec 2012 17:06:45 +0100 Date: Fri, 7 Dec 2012 17:06:45 +0100 From: Jakub Jelinek To: Richard Biener Cc: Jan Hubicka , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Don't drop DECL_INITIAL if -g for DWARF2+ (PR fortran/55395) Message-ID: <20121207160645.GA2315@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20121206190628.GN2315@tucnak.redhat.com> <20121207095008.GR2315@tucnak.redhat.com> <20121207105436.GU2315@tucnak.redhat.com> <20121207113322.GV2315@tucnak.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Fri, Dec 07, 2012 at 12:36:58PM +0100, Richard Biener wrote: > Hmm. Then make it DINFO_LEVEL_NONE and put in a fixme comment refering > to the bugreport. Here is what I've committed after another bootstrap/regtest: 2012-12-07 Jakub Jelinek PR fortran/55395 * varpool.c (varpool_remove_node): Don't drop DECL_INITIAL for -g for any kind of debug info. Jakub --- gcc/varpool.c.jj 2012-12-06 21:34:16.000000000 +0100 +++ gcc/varpool.c 2012-12-07 13:25:42.005710625 +0100 @@ -63,12 +63,8 @@ varpool_remove_node (struct varpool_node && !DECL_IN_CONSTANT_POOL (node->symbol.decl) /* Keep vtables for BINFO folding. */ && !DECL_VIRTUAL_P (node->symbol.decl) - /* dbxout output constant initializers for readonly vars. */ - && (!host_integerp (DECL_INITIAL (node->symbol.decl), 0) - || !TREE_READONLY (node->symbol.decl)) - /* dwarf2out can use most of the initializers. */ - && write_symbols != DWARF2_DEBUG - && write_symbols != VMS_AND_DWARF2_DEBUG) + /* FIXME: http://gcc.gnu.org/PR55395 */ + && debug_info_level == DINFO_LEVEL_NONE) DECL_INITIAL (node->symbol.decl) = error_mark_node; ggc_free (node); }