Patchwork [4/4] sparc: use FWCfgState* instead of void* for fw_cfg data

login
register
mail settings
Submitter Eduardo Habkost
Date Dec. 7, 2012, 4:07 p.m.
Message ID <1354896456-21120-5-git-send-email-ehabkost@redhat.com>
Download mbox | patch
Permalink /patch/204561/
State New
Headers show

Comments

Eduardo Habkost - Dec. 7, 2012, 4:07 p.m.
There's no point in using void* if all functions dealing with that data
use FWCfgState*.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Blue Swirl <blauwirbel@gmail.com>
---
 hw/sun4m.c | 6 +++---
 hw/sun4u.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

Patch

diff --git a/hw/sun4m.c b/hw/sun4m.c
index 1a78676..efcd5dd 100644
--- a/hw/sun4m.c
+++ b/hw/sun4m.c
@@ -866,7 +866,7 @@  static void sun4m_hw_init(const struct sun4m_hwdef *hwdef, ram_addr_t RAM_size,
     qemu_irq *cpu_halt;
     unsigned long kernel_size;
     DriveInfo *fd[MAX_FD];
-    void *fw_cfg;
+    FWCfgState *fw_cfg;
     unsigned int num_vsimms;
 
     /* init CPUs */
@@ -1576,7 +1576,7 @@  static void sun4d_hw_init(const struct sun4d_hwdef *hwdef, ram_addr_t RAM_size,
         espdma_irq, ledma_irq;
     qemu_irq esp_reset, dma_enable;
     unsigned long kernel_size;
-    void *fw_cfg;
+    FWCfgState *fw_cfg;
     DeviceState *dev;
 
     /* init CPUs */
@@ -1776,7 +1776,7 @@  static void sun4c_hw_init(const struct sun4c_hwdef *hwdef, ram_addr_t RAM_size,
     qemu_irq fdc_tc;
     unsigned long kernel_size;
     DriveInfo *fd[MAX_FD];
-    void *fw_cfg;
+    FWCfgState *fw_cfg;
     DeviceState *dev;
     unsigned int i;
 
diff --git a/hw/sun4u.c b/hw/sun4u.c
index b2b51e3..8a7f52d 100644
--- a/hw/sun4u.c
+++ b/hw/sun4u.c
@@ -812,7 +812,7 @@  static void sun4uv_init(MemoryRegion *address_space_mem,
     qemu_irq *ivec_irqs, *pbm_irqs;
     DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS];
     DriveInfo *fd[MAX_FD];
-    void *fw_cfg;
+    FWCfgState *fw_cfg;
 
     /* init CPUs */
     cpu = cpu_devinit(cpu_model, hwdef);