Patchwork Is this normal?

login
register
mail settings
Submitter Patrick McHardy
Date Jan. 27, 2009, 2:15 p.m.
Message ID <497F16F7.6020504@trash.net>
Download mbox | patch
Permalink /patch/20454/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Patrick McHardy - Jan. 27, 2009, 2:15 p.m.
Paweł Staszewski wrote:
> I have Linux that works as Router + traffic management with connection 
> tracking enabled but without making NAT
> 
> About 600Mbit/s TX and 600Mbit/s RX forwarded traffic
> 
> iptables -L -n -v -t raw
> Chain PREROUTING (policy ACCEPT 3340M packets, 2623G bytes)
> pkts bytes target     prot opt in     out     source               
> destination
> 3339M 2621G NOTRACK    all  --  *      *       0.0.0.0/0            
> 0.0.0.0/0
> 
> 
> kernel 2.6.28.2
> CPU: Core 2, speed 2999.98 MHz (estimated)
> Counted CPU_CLK_UNHALTED events (Clock cycles when not halted) with a 
> unit mask of 0x00 (Unhalted core cycles) count 100000
> samples  %        image name               app name                 
> symbol name
> 14544205 15.8604  vmlinux                  vmlinux                  
> ctnetlink_del_expect

This doesn't seem to be accurate, I'm guessing its really
ctnetlink_conntrack_event().

Does this patch make any difference?
Paweł Staszewski - Jan. 27, 2009, 2:26 p.m.
Patrick McHardy pisze:
> Paweł Staszewski wrote:
>> I have Linux that works as Router + traffic management with 
>> connection tracking enabled but without making NAT
>>
>> About 600Mbit/s TX and 600Mbit/s RX forwarded traffic
>>
>> iptables -L -n -v -t raw
>> Chain PREROUTING (policy ACCEPT 3340M packets, 2623G bytes)
>> pkts bytes target     prot opt in     out     source               
>> destination
>> 3339M 2621G NOTRACK    all  --  *      *       0.0.0.0/0            
>> 0.0.0.0/0
>>
>>
>> kernel 2.6.28.2
>> CPU: Core 2, speed 2999.98 MHz (estimated)
>> Counted CPU_CLK_UNHALTED events (Clock cycles when not halted) with a 
>> unit mask of 0x00 (Unhalted core cycles) count 100000
>> samples  %        image name               app name                 
>> symbol name
>> 14544205 15.8604  vmlinux                  vmlinux                  
>> ctnetlink_del_expect
>
> This doesn't seem to be accurate, I'm guessing its really
> ctnetlink_conntrack_event().
>
> Does this patch make any difference?

I will check this patch today at night.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paweł Staszewski - Jan. 28, 2009, 4:09 p.m.
after patch i have:

CPU: Core 2, speed 3000 MHz (estimated)
Counted CPU_CLK_UNHALTED events (Clock cycles when not halted) with a 
unit mask of 0x00 (Unhalted core cycles) count 100000
samples  %        image name               app name                 
symbol name
767616   13.0507  vmlinux                  vmlinux                  
u32_delete
291303    4.9526  vmlinux                  vmlinux                  
_raw_spin_trylock
269856    4.5880  vmlinux                  vmlinux                  
do_ipt_get_ctl
221887    3.7724  vmlinux                  vmlinux                  
devm_ioport_unmap
202405    3.4412  vmlinux                  vmlinux                  
devm_ioport_map
150375    2.5566  vmlinux                  vmlinux                  
native_calibrate_tsc
138476    2.3543  vmlinux                  vmlinux                  
update_persistent_clock
103328    1.7567  vmlinux                  vmlinux                  
update_wall_time
101648    1.7282  vmlinux                  vmlinux                  
e1000_xmit_frame
100776    1.7134  vmlinux                  vmlinux                  
__ip_route_output_key
94866     1.6129  vmlinux                  vmlinux                  
dev_ethtool
88844     1.5105  vmlinux                  vmlinux                  
dev_queue_xmit
88582     1.5060  vmlinux                  vmlinux                  
ixgbe_update_rx_dca
87747     1.4918  vmlinux                  vmlinux                  
__pskb_pull_tail
86888     1.4772  vmlinux                  vmlinux                  
irq_entries_start
77941     1.3251  vmlinux                  vmlinux                  
ixgbe_configure
76646     1.3031  vmlinux                  vmlinux                  
ixgbe_clean_rx_irq
75933     1.2910  vmlinux                  vmlinux                  
ixgbe_alloc_rx_buffers
75538     1.2843  vmlinux                  vmlinux                  
e1000_get_eeprom
75380     1.2816  vmlinux                  vmlinux                  
ixgbe_vlan_rx_kill_vid
71534     1.2162  vmlinux                  vmlinux                  
e1000e_update_stats
70017     1.1904  vmlinux                  vmlinux                  
ip_route_input
67435     1.1465  vmlinux                  vmlinux                  udp_mt
66901     1.1374  vmlinux                  vmlinux                  
mach_set_rtc_mmss
65824     1.1191  vmlinux                  vmlinux                  
htb_dequeue
63405     1.0780  vmlinux                  vmlinux                  
text_poke
58282     0.9909  vmlinux                  vmlinux                  
devm_ioremap
57893     0.9843  vmlinux                  vmlinux                  
e1000_open
51794     0.8806  vmlinux                  vmlinux                  
ctrl_dumpfamily
49911     0.8486  vmlinux                  vmlinux                  
dev_seq_show
49514     0.8418  vmlinux                  vmlinux                  
skb_copy_and_csum_bits
49168     0.8359  vmlinux                  vmlinux                  
e1000_clean_rx_irq_ps
48879     0.8310  vmlinux                  vmlinux                  
ixgbe_setup_dca
45064     0.7662  vmlinux                  vmlinux                  
dev_unicast_sync
43600     0.7413  vmlinux                  vmlinux                  
ixgbe_clean_tx_irq
42552     0.7235  vmlinux                  vmlinux                  
ixgbe_xmit_frame
41313     0.7024  vmlinux                  vmlinux                  
_format_mac_addr
41011     0.6973  vmlinux                  vmlinux                  
pcim_iomap_regions
40975     0.6966  vmlinux                  vmlinux                  sfq_init
38783     0.6594  vmlinux                  vmlinux                  
tc_ctl_action
35913     0.6106  vmlinux                  vmlinux                  
hfsc_reset_qdisc
34672     0.5895  vmlinux                  vmlinux                  
xt_check_match
32446     0.5516  vmlinux                  vmlinux                  
packet_rcv
31861     0.5417  vmlinux                  vmlinux                  
__lru_cache_add
31555     0.5365  vmlinux                  vmlinux                  s_stop
30430     0.5174  vmlinux                  vmlinux                  
ip_defrag
30235     0.5140  vmlinux                  vmlinux                  
rwlock_bug
29314     0.4984  vmlinux                  vmlinux                  htb_init
29236     0.4971  vmlinux                  vmlinux                  
net_tx_action
29062     0.4941  vmlinux                  vmlinux                  
apply_alternatives
28241     0.4801  vmlinux                  vmlinux                  
tick_nohz_restart_sched_tick
27626     0.4697  vmlinux                  vmlinux                  
do_sysinfo
25705     0.4370  vmlinux                  vmlinux                  
htb_delete
25336     0.4308  vmlinux                  vmlinux                  
e1000_clean_jumbo_rx_irq
24546     0.4173  vmlinux                  vmlinux                  
tick_init_jiffy_update
22883     0.3890  vmlinux                  vmlinux                  
ixgbe_init_interrupt_scheme

Patrick McHardy pisze:
> Paweł Staszewski wrote:
>> I have Linux that works as Router + traffic management with 
>> connection tracking enabled but without making NAT
>>
>> About 600Mbit/s TX and 600Mbit/s RX forwarded traffic
>>
>> iptables -L -n -v -t raw
>> Chain PREROUTING (policy ACCEPT 3340M packets, 2623G bytes)
>> pkts bytes target     prot opt in     out     source               
>> destination
>> 3339M 2621G NOTRACK    all  --  *      *       0.0.0.0/0            
>> 0.0.0.0/0
>>
>>
>> kernel 2.6.28.2
>> CPU: Core 2, speed 2999.98 MHz (estimated)
>> Counted CPU_CLK_UNHALTED events (Clock cycles when not halted) with a 
>> unit mask of 0x00 (Unhalted core cycles) count 100000
>> samples  %        image name               app name                 
>> symbol name
>> 14544205 15.8604  vmlinux                  vmlinux                  
>> ctnetlink_del_expect
>
> This doesn't seem to be accurate, I'm guessing its really
> ctnetlink_conntrack_event().
>
> Does this patch make any difference?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/net/netfilter/nf_conntrack_core.h b/include/net/netfilter/nf_conntrack_core.h
index e78afe7..c25068e 100644
--- a/include/net/netfilter/nf_conntrack_core.h
+++ b/include/net/netfilter/nf_conntrack_core.h
@@ -59,7 +59,7 @@  static inline int nf_conntrack_confirm(struct sk_buff *skb)
 	struct nf_conn *ct = (struct nf_conn *)skb->nfct;
 	int ret = NF_ACCEPT;
 
-	if (ct) {
+	if (ct && ct != &nf_conntrack_untracked) {
 		if (!nf_ct_is_confirmed(ct) && !nf_ct_is_dying(ct))
 			ret = __nf_conntrack_confirm(skb);
 		nf_ct_deliver_cached_events(ct);