Patchwork [4/5] powerpc/83xx: apply mpc8360e quirk for kmeter1 only when par_io is present

login
register
mail settings
Submitter Holger Brunck
Date Dec. 7, 2012, 3:09 p.m.
Message ID <1354892956-14623-4-git-send-email-holger.brunck@keymile.com>
Download mbox | patch
Permalink /patch/204526/
State Accepted
Commit 9c2f451e0db90d257c745df1d967c8010f14f0dd
Delegated to: Kumar Gala
Headers show

Comments

Holger Brunck - Dec. 7, 2012, 3:09 p.m.
From: Gerlando Falauto <gerlando.falauto@keymile.com>

There is no point in applying this quirk when par_io is not present.

Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
cc: Kumar Gala <galak@kernel.crashing.org>
---
 arch/powerpc/platforms/83xx/km83xx.c |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

Patch

diff --git a/arch/powerpc/platforms/83xx/km83xx.c b/arch/powerpc/platforms/83xx/km83xx.c
index 88b1af0..bf4c447 100644
--- a/arch/powerpc/platforms/83xx/km83xx.c
+++ b/arch/powerpc/platforms/83xx/km83xx.c
@@ -148,11 +148,13 @@  static void __init mpc83xx_km_setup_arch(void)
 
 		for_each_node_by_name(np, "ucc")
 			par_io_of_config(np);
-	}
-	np = of_find_compatible_node(NULL, "network", "ucc_geth");
-	if (np != NULL) {
-		quirk_mpc8360e_qe_enet10();
-		of_node_put(np);
+
+		/* Only apply this quirk when par_io is available */
+		np = of_find_compatible_node(NULL, "network", "ucc_geth");
+		if (np != NULL) {
+			quirk_mpc8360e_qe_enet10();
+			of_node_put(np);
+		}
 	}
 #endif	/* CONFIG_QUICC_ENGINE */
 }