From patchwork Fri Dec 7 11:39:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [13/13] pc_sysfw: Plug memory leak on pc_fw_add_pflash_drv() error path Date: Fri, 07 Dec 2012 01:39:12 -0000 From: Stefan Hajnoczi X-Patchwork-Id: 204463 Message-Id: <1354880352-9597-14-git-send-email-stefanha@redhat.com> To: Cc: Anthony Liguori , Markus Armbruster , Stefan Hajnoczi From: Markus Armbruster Harmless, because we the error inevitably leads to another, fatal one in pc_system_flash_init(): PC system firmware (pflash) not available. Fix it anyway. Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- hw/pc_sysfw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/pc_sysfw.c b/hw/pc_sysfw.c index 9d7c5f4..40bced2 100644 --- a/hw/pc_sysfw.c +++ b/hw/pc_sysfw.c @@ -98,7 +98,9 @@ static void pc_fw_add_pflash_drv(void) return; } - drive_init(opts, machine->use_scsi); + if (!drive_init(opts, machine->use_scsi)) { + qemu_opts_del(opts); + } } static void pc_system_flash_init(MemoryRegion *rom_memory,