Patchwork fbv: add license info

login
register
mail settings
Submitter Stephan Hoffmann
Date Dec. 7, 2012, 10:12 a.m.
Message ID <1354875156-28654-1-git-send-email-sho@relinux.de>
Download mbox | patch
Permalink /patch/204444/
State Accepted
Commit 4bd01ac2bfc9617821e0e923acef83f7608d0507
Headers show

Comments

Stephan Hoffmann - Dec. 7, 2012, 10:12 a.m.
Signed-off-by: Stephan Hoffmann <sho@relinux.de>
---
 package/fbv/fbv.mk |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Arnout Vandecappelle - Dec. 9, 2012, 3:05 p.m.
On 07/12/12 11:12, Stephan Hoffmann wrote:
> Signed-off-by: Stephan Hoffmann<sho@relinux.de>
> ---
>   package/fbv/fbv.mk |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/package/fbv/fbv.mk b/package/fbv/fbv.mk
> index 7949e99..f697fe8 100644
> --- a/package/fbv/fbv.mk
> +++ b/package/fbv/fbv.mk
> @@ -7,6 +7,9 @@ FBV_VERSION:=1.0b
>   FBV_SOURCE:=fbv-$(FBV_VERSION).tar.gz
>   FBV_SITE:=http://s-tech.elsat.net.pl/fbv
>
> +FBV_LICENSE = GPLv2

  Although the README and COPYING files claim it's version 2, all source files
say version 2 or later.

  I'm not sure what to do here.  The safe option is:

FBV_LICENSE = GPLv2 (or later?)


> +FBV_LICENSE_FILES = COPYING

  That file is just referring to the GNU website, so it doesn't help much
to use that as the license file. Still, it's better than nothing I guess.


  Regards,
  Arnout

> +
>   ### image format dependencies and configure options
>   FBV_DEPENDENCIES = # empty
>   FBV_CONFIGURE_OPTS = # empty
Peter Korsgaard - Dec. 9, 2012, 8:44 p.m.
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >> +FBV_LICENSE = GPLv2

 Arnout>  Although the README and COPYING files claim it's version 2,
 Arnout> all source files say version 2 or later.

 Arnout>  I'm not sure what to do here.  The safe option is:

 Arnout> FBV_LICENSE = GPLv2 (or later?)

Or simply GPLv2. It might allow later as well, but GPLv2 is certainly
true.
Peter Korsgaard - Dec. 16, 2012, 10:33 a.m.
>>>>> "Stephan" == Stephan Hoffmann <sho@relinux.de> writes:

 Stephan> Signed-off-by: Stephan Hoffmann <sho@relinux.de>

Committed, thanks.

Patch

diff --git a/package/fbv/fbv.mk b/package/fbv/fbv.mk
index 7949e99..f697fe8 100644
--- a/package/fbv/fbv.mk
+++ b/package/fbv/fbv.mk
@@ -7,6 +7,9 @@  FBV_VERSION:=1.0b
 FBV_SOURCE:=fbv-$(FBV_VERSION).tar.gz
 FBV_SITE:=http://s-tech.elsat.net.pl/fbv
 
+FBV_LICENSE = GPLv2
+FBV_LICENSE_FILES = COPYING
+
 ### image format dependencies and configure options
 FBV_DEPENDENCIES = # empty
 FBV_CONFIGURE_OPTS = # empty