Patchwork acpi: pcc: make this test an Intel only test

login
register
mail settings
Submitter Colin King
Date Dec. 7, 2012, 9:10 a.m.
Message ID <1354871423-12054-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/204435/
State Accepted
Headers show

Comments

Colin King - Dec. 7, 2012, 9:10 a.m.
From: Colin Ian King <colin.king@canonical.com>

The PCC test really doesn't make sense on other architectures so
disable this for non-Intel builds.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/pcc/pcc.c | 4 ++++
 1 file changed, 4 insertions(+)
Keng-Yu Lin - Dec. 12, 2012, 7:56 a.m.
On Fri, Dec 7, 2012 at 5:10 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The PCC test really doesn't make sense on other architectures so
> disable this for non-Intel builds.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/pcc/pcc.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/acpi/pcc/pcc.c b/src/acpi/pcc/pcc.c
> index c3b6a38..3848014 100644
> --- a/src/acpi/pcc/pcc.c
> +++ b/src/acpi/pcc/pcc.c
> @@ -18,6 +18,8 @@
>   */
>  #include "fwts.h"
>
> +#ifdef FWTS_ARCH_INTEL
> +
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <string.h>
> @@ -467,3 +469,5 @@ static fwts_framework_ops pcc_ops = {
>  };
>
>  FWTS_REGISTER(pcc, &pcc_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH);
> +
> +#endif
> --
> 1.8.0
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Dec. 14, 2012, 12:05 a.m.
On 12/07/2012 05:10 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The PCC test really doesn't make sense on other architectures so
> disable this for non-Intel builds.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/pcc/pcc.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/src/acpi/pcc/pcc.c b/src/acpi/pcc/pcc.c
> index c3b6a38..3848014 100644
> --- a/src/acpi/pcc/pcc.c
> +++ b/src/acpi/pcc/pcc.c
> @@ -18,6 +18,8 @@
>    */
>   #include "fwts.h"
>
> +#ifdef FWTS_ARCH_INTEL
> +
>   #include <stdio.h>
>   #include <stdlib.h>
>   #include <string.h>
> @@ -467,3 +469,5 @@ static fwts_framework_ops pcc_ops = {
>   };
>
>   FWTS_REGISTER(pcc, &pcc_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH);
> +
> +#endif
>
Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/acpi/pcc/pcc.c b/src/acpi/pcc/pcc.c
index c3b6a38..3848014 100644
--- a/src/acpi/pcc/pcc.c
+++ b/src/acpi/pcc/pcc.c
@@ -18,6 +18,8 @@ 
  */
 #include "fwts.h"
 
+#ifdef FWTS_ARCH_INTEL
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -467,3 +469,5 @@  static fwts_framework_ops pcc_ops = {
 };
 
 FWTS_REGISTER(pcc, &pcc_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH);
+
+#endif