From patchwork Fri Dec 7 09:05:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 204432 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 354C02C009F for ; Fri, 7 Dec 2012 20:05:55 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TgtsY-00024W-Q3; Fri, 07 Dec 2012 09:05:54 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TgtsX-00024M-C7 for fwts-devel@lists.ubuntu.com; Fri, 07 Dec 2012 09:05:53 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TgtsX-0000UR-7r for fwts-devel@lists.ubuntu.com; Fri, 07 Dec 2012 09:05:53 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH 1/2] lib: fwts_cmos: fix build error with non-Intel architectures Date: Fri, 7 Dec 2012 09:05:50 +0000 Message-Id: <1354871151-11593-2-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1354871151-11593-1-git-send-email-colin.king@canonical.com> References: <1354871151-11593-1-git-send-email-colin.king@canonical.com> X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King The dummy no-op CMOS fwts_cmos_read() for non-Intel builds is causing build failures because of the -Wextra flag: fwts_cmos.c: In function 'fwts_cmos_read': fwts_cmos.c:53:34: error: unused parameter 'offset' [-Werror=unused-parameter] fwts_cmos.c:53:51: error: unused parameter 'value' [-Werror=unused-parameter] This fixes this and makes the no-op function return a known garbage value. Signed-off-by: Colin Ian King Acked-by: Keng-Yu Lin Acked-by: Ivan Hu --- src/lib/src/fwts_cmos.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/lib/src/fwts_cmos.c b/src/lib/src/fwts_cmos.c index 583bbb4..7b0ca40 100644 --- a/src/lib/src/fwts_cmos.c +++ b/src/lib/src/fwts_cmos.c @@ -52,6 +52,10 @@ int fwts_cmos_read(const uint8_t offset, uint8_t *value) #else int fwts_cmos_read(const uint8_t offset, uint8_t *value) { + FWTS_UNUSED(offset); + + *value = ~0; /* Fake a failed read */ + return FWTS_ERROR; } #endif