From patchwork Fri Dec 7 09:05:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/2] lib: fwts_cmos: fix build error with non-Intel architectures Date: Thu, 06 Dec 2012 23:05:50 -0000 From: Colin King X-Patchwork-Id: 204432 Message-Id: <1354871151-11593-2-git-send-email-colin.king@canonical.com> To: fwts-devel@lists.ubuntu.com From: Colin Ian King The dummy no-op CMOS fwts_cmos_read() for non-Intel builds is causing build failures because of the -Wextra flag: fwts_cmos.c: In function 'fwts_cmos_read': fwts_cmos.c:53:34: error: unused parameter 'offset' [-Werror=unused-parameter] fwts_cmos.c:53:51: error: unused parameter 'value' [-Werror=unused-parameter] This fixes this and makes the no-op function return a known garbage value. Signed-off-by: Colin Ian King Acked-by: Keng-Yu Lin Acked-by: Ivan Hu --- src/lib/src/fwts_cmos.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/lib/src/fwts_cmos.c b/src/lib/src/fwts_cmos.c index 583bbb4..7b0ca40 100644 --- a/src/lib/src/fwts_cmos.c +++ b/src/lib/src/fwts_cmos.c @@ -52,6 +52,10 @@ int fwts_cmos_read(const uint8_t offset, uint8_t *value) #else int fwts_cmos_read(const uint8_t offset, uint8_t *value) { + FWTS_UNUSED(offset); + + *value = ~0; /* Fake a failed read */ + return FWTS_ERROR; } #endif