Patchwork perl: refactor configure step,

login
register
mail settings
Submitter Francois Perrad
Date Dec. 7, 2012, 7:38 a.m.
Message ID <1354865887-6720-1-git-send-email-francois.perrad@gadz.org>
Download mbox | patch
Permalink /patch/204412/
State Accepted
Commit efddfcbe6dc531145fe3f4d7a39818e8e27d77b9
Headers show

Comments

Francois Perrad - Dec. 7, 2012, 7:38 a.m.
after discussion with Perl-Cross's author (Alex Suykov)

Note: Using -A with variables that aren't option lists makes little sense.

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/perl/perl.mk |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
Arnout Vandecappelle - Dec. 13, 2012, 10:30 a.m.
On 07/12/12 08:38, Francois Perrad wrote:
> after discussion with Perl-Cross's author (Alex Suykov)

  This splitting of the commit message looks funny in the oneline log...

>
> Note: Using -A with variables that aren't option lists makes little sense.

  Then I misunderstood the meaning of -A: I thought it was meant to override
whatever has been autodetected, while -D can still be overridden by the
autodetection. But the documentation isn't particularly clear about this.
And I guess Alex Suykov should know :-)

>
> Signed-off-by: Francois Perrad<francois.perrad@gadz.org>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
  (build-test on a minimal internal toolchain)


  Regards,
  Arnout

> ---
>   package/perl/perl.mk |   12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/package/perl/perl.mk b/package/perl/perl.mk
> index a86ee2a..da54ef1 100644
> --- a/package/perl/perl.mk
> +++ b/package/perl/perl.mk
> @@ -57,12 +57,12 @@ PERL_CONF_OPT = \
>   	-Dld="$(TARGET_CC_NOCCACHE)" \
>   	-Dccflags="$(TARGET_CFLAGS)" \
>   	-Dldflags="$(TARGET_LDFLAGS) -lm" \
> -	-A define:mydomain="" \
> -	-A define:myhostname="$(BR2_TARGET_GENERIC_HOSTNAME)" \
> -	-A define:myuname="Buildroot $(BR2_VERSION_FULL)" \
> -	-A define:osname=linux \
> -	-A define:osvers=$(LINUX_VERSION) \
> -	-A define:perladmin=root
> +	-Dmydomain="" \
> +	-Dmyhostname="$(BR2_TARGET_GENERIC_HOSTNAME)" \
> +	-Dmyuname="Buildroot $(BR2_VERSION_FULL)" \
> +	-Dosname=linux \
> +	-Dosvers=$(LINUX_VERSION) \
> +	-Dperladmin=root
>
>   ifeq ($(shell expr $(PERL_VERSION_MAJOR) % 2), 1)
>       PERL_CONF_OPT += -Dusedevel
Peter Korsgaard - Dec. 16, 2012, 12:09 a.m.
>>>>> "Francois" == Francois Perrad <fperrad@gmail.com> writes:

 Francois> after discussion with Perl-Cross's author (Alex Suykov)

 Francois> Note: Using -A with variables that aren't option lists makes
 Francois> little sense.

Committed, thanks.

Patch

diff --git a/package/perl/perl.mk b/package/perl/perl.mk
index a86ee2a..da54ef1 100644
--- a/package/perl/perl.mk
+++ b/package/perl/perl.mk
@@ -57,12 +57,12 @@  PERL_CONF_OPT = \
 	-Dld="$(TARGET_CC_NOCCACHE)" \
 	-Dccflags="$(TARGET_CFLAGS)" \
 	-Dldflags="$(TARGET_LDFLAGS) -lm" \
-	-A define:mydomain="" \
-	-A define:myhostname="$(BR2_TARGET_GENERIC_HOSTNAME)" \
-	-A define:myuname="Buildroot $(BR2_VERSION_FULL)" \
-	-A define:osname=linux \
-	-A define:osvers=$(LINUX_VERSION) \
-	-A define:perladmin=root
+	-Dmydomain="" \
+	-Dmyhostname="$(BR2_TARGET_GENERIC_HOSTNAME)" \
+	-Dmyuname="Buildroot $(BR2_VERSION_FULL)" \
+	-Dosname=linux \
+	-Dosvers=$(LINUX_VERSION) \
+	-Dperladmin=root
 
 ifeq ($(shell expr $(PERL_VERSION_MAJOR) % 2), 1)
     PERL_CONF_OPT += -Dusedevel