| Message ID | 1354838913-20084-1-git-send-email-dinggnu@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Fri, Dec 07, 2012 at 12:06:44AM +0000, Cong Ding wrote: > the variables zero and unres_qlen_max are only used when CONFIG_SYSCTL is > defined, otherwise it causes the following sparse warning when we turn on > CONFIG_SYSCTL. sorry for disturbing again, the sparse warning is net/core/neighbour.c:65:12: warning: ‘zero’ defined but not used [-Wunused-variable] net/core/neighbour.c:66:12: warning: ‘unres_qlen_max’ defined but not used [-Wunused-variable] it happens if we turn off CONFIG_SYSCTL. > > Signed-off-by: Cong Ding <dinggnu@gmail.com> > --- > net/core/neighbour.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/net/core/neighbour.c b/net/core/neighbour.c > index 36fc692..4a15278 100644 > --- a/net/core/neighbour.c > +++ b/net/core/neighbour.c > @@ -62,8 +62,10 @@ static void __neigh_notify(struct neighbour *n, int type, int flags); > static void neigh_update_notify(struct neighbour *neigh); > static int pneigh_ifdown(struct neigh_table *tbl, struct net_device *dev); > > +#ifdef CONFIG_SYSCTL > static int zero; > static int unres_qlen_max = INT_MAX / SKB_TRUESIZE(ETH_FRAME_LEN); > +#endif > > static struct neigh_table *neigh_tables; > #ifdef CONFIG_PROC_FS > -- > 1.7.4.5 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Cong Ding <dinggnu@gmail.com> Date: Fri, 7 Dec 2012 00:15:47 +0000 > On Fri, Dec 07, 2012 at 12:06:44AM +0000, Cong Ding wrote: >> the variables zero and unres_qlen_max are only used when CONFIG_SYSCTL is >> defined, otherwise it causes the following sparse warning when we turn on >> CONFIG_SYSCTL. > sorry for disturbing again, the sparse warning is > net/core/neighbour.c:65:12: warning: ‘zero’ defined but not used [-Wunused-variable] > net/core/neighbour.c:66:12: warning: ‘unres_qlen_max’ defined but not used [-Wunused-variable] > > it happens if we turn off CONFIG_SYSCTL. A patch for this has already in my tree for nearly a whole day.
Cong Ding said, at 2012/12/7 8:15: > On Fri, Dec 07, 2012 at 12:06:44AM +0000, Cong Ding wrote: >> the variables zero and unres_qlen_max are only used when CONFIG_SYSCTL is >> defined, otherwise it causes the following sparse warning when we turn on >> CONFIG_SYSCTL. > sorry for disturbing again, the sparse warning is > net/core/neighbour.c:65:12: warning: ‘zero’ defined but not used [-Wunused-variable] > net/core/neighbour.c:66:12: warning: ‘unres_qlen_max’ defined but not used [-Wunused-variable] > > it happens if we turn off CONFIG_SYSCTL. It has been fixed yesterday. see b93196dc5af7729ff7cc50d3d322ab1a364aa14f > >> >> Signed-off-by: Cong Ding <dinggnu@gmail.com> >> --- >> net/core/neighbour.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/net/core/neighbour.c b/net/core/neighbour.c >> index 36fc692..4a15278 100644 >> --- a/net/core/neighbour.c >> +++ b/net/core/neighbour.c >> @@ -62,8 +62,10 @@ static void __neigh_notify(struct neighbour *n, int type, int flags); >> static void neigh_update_notify(struct neighbour *neigh); >> static int pneigh_ifdown(struct neigh_table *tbl, struct net_device *dev); >> >> +#ifdef CONFIG_SYSCTL >> static int zero; >> static int unres_qlen_max = INT_MAX / SKB_TRUESIZE(ETH_FRAME_LEN); >> +#endif >> >> static struct neigh_table *neigh_tables; >> #ifdef CONFIG_PROC_FS >> -- >> 1.7.4.5 >> > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 36fc692..4a15278 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -62,8 +62,10 @@ static void __neigh_notify(struct neighbour *n, int type, int flags); static void neigh_update_notify(struct neighbour *neigh); static int pneigh_ifdown(struct neigh_table *tbl, struct net_device *dev); +#ifdef CONFIG_SYSCTL static int zero; static int unres_qlen_max = INT_MAX / SKB_TRUESIZE(ETH_FRAME_LEN); +#endif static struct neigh_table *neigh_tables; #ifdef CONFIG_PROC_FS
the variables zero and unres_qlen_max are only used when CONFIG_SYSCTL is defined, otherwise it causes the following sparse warning when we turn on CONFIG_SYSCTL. Signed-off-by: Cong Ding <dinggnu@gmail.com> --- net/core/neighbour.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)