Patchwork ahci_platform: make structs static

login
register
mail settings
Submitter Brian Norris
Date Dec. 6, 2012, 7:44 a.m.
Message ID <1354779860-8655-1-git-send-email-computersforpeace@gmail.com>
Download mbox | patch
Permalink /patch/204169/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Brian Norris - Dec. 6, 2012, 7:44 a.m.
These structs are used only for ahci_platform.c, so they should be
static. Thanks to Fengguang for the (automated) suggestion.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>
---
 drivers/ata/ahci_platform.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Jeff Garzik - Dec. 14, 2012, 2:39 p.m.
On 12/06/2012 02:44 AM, Brian Norris wrote:
> These structs are used only for ahci_platform.c, so they should be
> static. Thanks to Fengguang for the (automated) suggestion.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Fengguang Wu <fengguang.wu@intel.com>
> ---
>   drivers/ata/ahci_platform.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

applied



--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
index 1d90690..1cc467b 100644
--- a/drivers/ata/ahci_platform.c
+++ b/drivers/ata/ahci_platform.c
@@ -49,12 +49,12 @@  static struct platform_device_id ahci_devtype[] = {
 };
 MODULE_DEVICE_TABLE(platform, ahci_devtype);
 
-struct ata_port_operations ahci_platform_ops = {
+static struct ata_port_operations ahci_platform_ops = {
 	.inherits	= &ahci_ops,
 	.host_stop	= ahci_host_stop,
 };
 
-struct ata_port_operations ahci_platform_retry_srst_ops = {
+static struct ata_port_operations ahci_platform_retry_srst_ops = {
 	.inherits	= &ahci_pmp_retry_srst_ops,
 	.host_stop	= ahci_host_stop,
 };
@@ -323,7 +323,7 @@  disable_unprepare_clk:
 }
 #endif
 
-SIMPLE_DEV_PM_OPS(ahci_pm_ops, ahci_suspend, ahci_resume);
+static SIMPLE_DEV_PM_OPS(ahci_pm_ops, ahci_suspend, ahci_resume);
 
 static const struct of_device_id ahci_of_match[] = {
 	{ .compatible = "snps,spear-ahci", },