From patchwork Thu Dec 6 00:46:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 204080 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 579CC2C00EC for ; Thu, 6 Dec 2012 11:51:46 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 56D464A140; Thu, 6 Dec 2012 01:51:32 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FyBTT2xQpcfn; Thu, 6 Dec 2012 01:51:32 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6F8234A162; Thu, 6 Dec 2012 01:50:32 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9794B4A137 for ; Thu, 6 Dec 2012 01:50:24 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KKXfeQE1HUVM for ; Thu, 6 Dec 2012 01:50:23 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-yh0-f74.google.com (mail-yh0-f74.google.com [209.85.213.74]) by theia.denx.de (Postfix) with ESMTPS id EC1324A129 for ; Thu, 6 Dec 2012 01:50:16 +0100 (CET) Received: by mail-yh0-f74.google.com with SMTP id 10so647321yhl.3 for ; Wed, 05 Dec 2012 16:50:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=mFHkHxpIblpi3+lZomEFw31qgEi62OMytxXuyXtMoVA=; b=XjD2huQwtnCsSoIpiQ6jtfmRjhCqcpU8JvbjWGavWxCT1pQzknTnOs+GjV9/NitTtW qrWhWXcb8EiXRt1iKxsapn4d4eQcwr/vrEd2W+/4dYbjn3XqoZFDGRReNz+LGy/YxMfd dIk8b3NAYjpAOKE0jNcm9EWGrn/WDR4be/FU1NAoZPHEmwG9P1hRLg1lVgXVkzYb6jFR 3g7tgobVdj2rJheM4jRELFh4U7e3tKeInc2LKqu9R7pjYzznLge9brguN4OAz1mvz5hn dvXbLAgsCxDmxJxIzHmb5wKYlP2olNna7WG6yyoQfknwOxB+bY2lwRIr6Qzx4g3ikg55 R+dg== Received: by 10.100.237.4 with SMTP id k4mr3240728anh.25.1354755014862; Wed, 05 Dec 2012 16:50:14 -0800 (PST) Received: from wpzn3.hot.corp.google.com (216-239-44-65.google.com [216.239.44.65]) by gmr-mx.google.com with ESMTPS id i7si522650yhj.6.2012.12.05.16.50.14 (version=TLSv1/SSLv3 cipher=AES128-SHA); Wed, 05 Dec 2012 16:50:14 -0800 (PST) Received: from kaka.mtv.corp.google.com (kaka.mtv.corp.google.com [172.22.73.79]) by wpzn3.hot.corp.google.com (Postfix) with ESMTP id B0EAC100049; Wed, 5 Dec 2012 16:50:14 -0800 (PST) Received: by kaka.mtv.corp.google.com (Postfix, from userid 121222) id 5D31A160A46; Wed, 5 Dec 2012 16:50:14 -0800 (PST) From: Simon Glass To: U-Boot Mailing List Date: Wed, 5 Dec 2012 16:46:32 -0800 Message-Id: <1354754807-21449-6-git-send-email-sjg@chromium.org> X-Mailer: git-send-email 1.7.7.3 In-Reply-To: <1354754807-21449-1-git-send-email-sjg@chromium.org> References: <1354754807-21449-1-git-send-email-sjg@chromium.org> X-Gm-Message-State: ALoCoQmqNXWNN4qYZ/w4dSP0KplpaCJmxUo+qPwjjA4YCydY3gLxDYl8RzXbgGqOjvTSS8KgcN+Jwe7V4khRhPEk9uy8SCJ/u9+BjiMIDMd28EuS0ED4nbmFj2n3qDsUdATA7DaUt+OrbXK7PUKTVzeSfsappLQXJb8/5J5Z6+Fpf8MpNqH7cI3LnxQjcpRRs8mZgs9pd4+b Cc: Tom Rini , Vincent Palatin Subject: [U-Boot] [PATCH v3 05/20] stdio: remove useless strncpy X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de From: Vincent Palatin The name is already copied when we memcpy() the whole structure. This is because struct stdio_dev has this field: char name[16]; /* Device name */ So the data is inline, rather than being a pointer. Signed-off-by: Vincent Palatin Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: - Add more comments to the stdio strncpy commit message common/stdio.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/common/stdio.c b/common/stdio.c index 9f48e5f..97ff9cf 100644 --- a/common/stdio.c +++ b/common/stdio.c @@ -135,7 +135,6 @@ struct stdio_dev* stdio_clone(struct stdio_dev *dev) return NULL; memcpy(_dev, dev, sizeof(struct stdio_dev)); - strncpy(_dev->name, dev->name, 16); return _dev; }