From patchwork Thu Dec 6 00:46:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [U-Boot,v3,05/20] stdio: remove useless strncpy From: Simon Glass X-Patchwork-Id: 204080 Message-Id: <1354754807-21449-6-git-send-email-sjg@chromium.org> To: U-Boot Mailing List Cc: Tom Rini , Vincent Palatin Date: Wed, 5 Dec 2012 16:46:32 -0800 From: Vincent Palatin The name is already copied when we memcpy() the whole structure. This is because struct stdio_dev has this field: char name[16]; /* Device name */ So the data is inline, rather than being a pointer. Signed-off-by: Vincent Palatin Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: - Add more comments to the stdio strncpy commit message common/stdio.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/common/stdio.c b/common/stdio.c index 9f48e5f..97ff9cf 100644 --- a/common/stdio.c +++ b/common/stdio.c @@ -135,7 +135,6 @@ struct stdio_dev* stdio_clone(struct stdio_dev *dev) return NULL; memcpy(_dev, dev, sizeof(struct stdio_dev)); - strncpy(_dev->name, dev->name, 16); return _dev; }